Skip to content

chore(vector-core): remove blanket allows#25748

Open
hjooh wants to merge 2 commits into
vectordotdev:masterfrom
hjooh:remove-blanket-cast-allows-vector-core
Open

chore(vector-core): remove blanket allows#25748
hjooh wants to merge 2 commits into
vectordotdev:masterfrom
hjooh:remove-blanket-cast-allows-vector-core

Conversation

@hjooh

@hjooh hjooh commented Jul 5, 2026

Copy link
Copy Markdown

Summary

Removes two blanket #![allow(...)] attributes from lib/vector-core/src/lib.rs:

  • clippy::cast_possible_wrap
  • clippy::cast_sign_loss

These two statements were suppressing lints across the entire vector-core crate. The contents of this PR replace them with specific suppressions at 6 locations (comments with justification/explanations were also modified or added at each location).

Vector configuration

N/A (no behavior changes).

How did you test this PR?

  • make check-clippy passes
  • make check-fmt passes
  • cargo vdev test: 3002/3005 tests pass, 3 failures seemed to be preexisting environment related issues unrelated to this change

Change Type

  • Bug fix
  • New feature
  • Dependencies
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

Related: #23659

Notes

  • Please read our Vector contributor resources.
  • Do not hesitate to use @vectordotdev/vector to reach out to us regarding this PR.
  • Some CI checks run only after we manually approve them.
    • We recommend adding a pre-push hook, please see this template.
    • Alternatively, we recommend running the following locally before pushing to the remote branch:
      • make fmt
      • make check-clippy (if there are failures it's possible some of them can be fixed with make clippy-fix)
      • make test
  • After a review is requested, please avoid force pushes to help us review incrementally.
    • Feel free to push as many commits as you want. They will be squashed into one before merging.
    • For example, you can run git merge origin master and git push.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run make build-licenses to regenerate the license inventory and commit the changes (if any). More details on the dd-rust-license-tool.

@github-actions github-actions Bot added the domain: core Anything related to core crates i.e. vector-core, core-common, etc label Jul 5, 2026
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@datadog-vectordotdev

This comment has been minimized.

@hjooh hjooh changed the title chore(vector-core): remove blanket allows in vector-core chore(vector-core): remove blanket allows Jul 5, 2026
@hjooh

hjooh commented Jul 5, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@hjooh

hjooh commented Jul 5, 2026

Copy link
Copy Markdown
Author

recheck

@hjooh hjooh marked this pull request as ready for review July 5, 2026 06:49
@hjooh hjooh requested a review from a team as a code owner July 5, 2026 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: core Anything related to core crates i.e. vector-core, core-common, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant