Repository navigation

fix(buffers): add nesting depth limit to prevent protobuf decode corruption - #25417

Closed

ganelo wants to merge 51 commits into

vectordotdev:masterfrom

ganelo:og/continue-protobuf-nesting-depth-limit

Commits on Mar 26, 2026

fix(buffers): add nesting depth limit to prevent protobuf decode corruption
connoryy
committed
f469b3f
fix: also check event metadata value for nesting depth
connoryy
committed
b05d98a
docs: replace approximate nesting formula with verified exact derivation
connoryy
committed
87d25cd
fix: lower MAX_NESTING_DEPTH from 33 to 32 to cover all proto paths
connoryy
committed
eff1c70
test: add EventWrapper path boundary test for vector sink gRPC
connoryy
committed
59de3d4
docs: simplify MAX_NESTING_DEPTH comment to state only verified facts
connoryy
committed
da1e2eb
docs: remove proto field names from MAX_NESTING_DEPTH comment
connoryy
committed
fbd398c
docs: simplify test comments to remove proto-specific terminology
connoryy
committed
2191d9b

Commits on Apr 1, 2026

make error slightly more informative
connoryy
committed
5046ec5
move imports
connoryy
committed
390c30b
add test
connoryy
committed
3eb9fb4

Commits on Apr 15, 2026

Commits on Apr 16, 2026

Add tests proving metadata_full is the tightest path
connoryy
committed
7b42478
style: auto-fix lint/format errors
connoryy
committed
bf5119c
Test full boundaries for loosest and tightest encoding paths
connoryy
committed
5ebc616
style: auto-fix lint/format errors
connoryy
committed
1021e1e
Add Trace to flat events test for uniformity
connoryy
committed
fbd2ad2
Use per-path depth limits: 33 for event data, 32 for metadata
connoryy
committed
8c81391
style: auto-fix lint/format errors
connoryy
committed
f0fc05a
Fix clippy doc_markdown lint
connoryy
committed
ef06620
Fix doc comment arithmetic and add native codec metadata tests
connoryy
committed
2a58740

Commits on May 12, 2026

Merge branch 'master' into og/continue-protobuf-nesting-depth-limit
oganel
committed
5f87a9f
Fix compile
oganel
committed
87038f5

Commits on May 18, 2026

fix(buffers): drop oversized events gracefully on disk-buffer write

oganel
and
claude
committed
57c9c91
fix(buffers): account for array vs object cost in nesting check

oganel
and
claude
committed
9d44c36

Commits on May 19, 2026

Merge branch 'master' into og/continue-protobuf-nesting-depth-limit
ganelo
authored
2447fda
fix(buffers): charge Value::Timestamp for one nesting frame

oganel
and
claude
committed
4993bb5

Commits on Jun 12, 2026

Merge branch 'master' into og/continue-protobuf-nesting-depth-limit
pront
authored
b5d2e9d

Commits on Jun 16, 2026

Update changelog.d/protobuf_nesting_depth_limit.fix.md

ganelo
and
pront
authored
0b639d4
refactor(buffers): move pre-encode filtering to Bufferable::filter_unencodable

oganel
and
claude
committed
eec68b2
fix(buffers): account for filter drops in buffer usage instrumentation

oganel
and
claude
committed
3598122
fix(console sink): keep per-event encoder failures from terminating the sink

oganel
and
claude
committed
860f40a
fix(buffers): skip filter_unencodable when disk is already full

oganel
and
claude
committed
f28b2a3

Commits on Jun 17, 2026

fix(codecs): silent-drop over-budget events from the native encoder

oganel
and
claude
committed
8a22d86
test(vector sink): pin PushEventsRequest decode boundary at the same budget

oganel
and
claude
committed
95ba0d0
fix(buffers): report disk-v2 filter drops via the ledger's usage handle

oganel
and
claude
committed
806371d
fix(sinks): finalize socket-sink encoder drops with explicit status

oganel
and
claude
committed
13999c5

Commits on Jun 18, 2026

fix(codecs): preserve framing for legitimate empty payloads

oganel
and
claude
committed
e90dd47
refactor(codecs): drop native-encoder nesting guard, scope fix to decode-owned paths

oganel
and
claude
committed
b172e6c
docs(buffers): document over-budget overflow-routing limitation in try_send
oganel
committed
f57988f