Skip to content

Add push-metrics command for Datadog integration #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pront wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add push-metrics command for Datadog integration #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da4252a
Add push-metrics command for Datadog integration
pront Jun 23, 2026
f0bae78
Fix four code review findings in push-metrics
pront Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ path = "src/lib.rs"

[dependencies]
# CLI
clap = { version = "4", features = ["derive"] }
clap = { version = "4", features = ["derive", "env"] }

# Error handling
anyhow = "1"
Expand Down
10 changes: 4 additions & 6 deletions src/commands/fetch_automated_review_stats.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,20 +111,18 @@ pub fn run(config: &Config, bot_login: Option<&str>, since: Option<&str>) -> Res
for pr in nodes {
// updatedAt >= mergedAt always, so this is a sound early-termination criterion.
let updated_at = pr["updatedAt"].as_str().unwrap_or("");
if let Some(ref ts) = since_ts {
if updated_at < ts.as_str() {
if let Some(ref ts) = since_ts
&& updated_at < ts.as_str() {
hit_boundary = true;
continue;
}
}

// Skip PRs merged before the cutoff (updated after it, e.g. a late comment).
let merged_at = pr["mergedAt"].as_str().unwrap_or("");
if let Some(ref ts) = since_ts {
if merged_at < ts.as_str() {
if let Some(ref ts) = since_ts
&& merged_at < ts.as_str() {
continue;
}
}

stats.prs_scanned += 1;
let pr_number = pr["number"].as_u64().unwrap_or(0);
Expand Down
44 changes: 22 additions & 22 deletions src/commands/generate_charts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ fn parse_i64(s: &str) -> i64 {

/// 1. Monthly trend: line chart with created vs closed series.
/// Also optionally adds dashed overlay lines for label type columns.
/// `type_overlays`: (series_name, columns_to_sum) — mirrors Python's df[matching].sum(axis=1).
///
/// `type_overlays`: (series_name, columns_to_sum) — mirrors Python's df[matching].sum(axis=1).
pub fn monthly_trend(
rows: &[&HashMap<String, String>],
created_col: &str,
Expand Down Expand Up @@ -137,13 +138,13 @@ pub fn monthly_trend(
.series(
Line::new()
.name("Created")
.data(created.iter().map(|v| *v).collect::<Vec<_>>())
.data(created.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_CREATED))),
)
.series(
Line::new()
.name("Closed")
.data(closed.iter().map(|v| *v).collect::<Vec<_>>())
.data(closed.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_CLOSED))),
);

Expand All @@ -155,7 +156,7 @@ pub fn monthly_trend(
chart = chart.series(
Line::new()
.name(series_name.as_str())
.data(vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(vals.to_vec())
.line_style(LineStyle::new().type_(LineStyleType::Dashed))
.item_style(ItemStyle::new().color(color(c))),
);
Expand Down Expand Up @@ -193,19 +194,19 @@ pub fn discussion_trend(rows: &[&HashMap<String, String>]) -> Chart {
.series(
Line::new()
.name("Created")
.data(created.iter().map(|v| *v).collect::<Vec<_>>())
.data(created.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_CREATED))),
)
.series(
Line::new()
.name("Closed")
.data(closed.iter().map(|v| *v).collect::<Vec<_>>())
.data(closed.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_CLOSED))),
)
.series(
Line::new()
.name("Answered")
.data(answered.iter().map(|v| *v).collect::<Vec<_>>())
.data(answered.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_ANSWERED))),
)
}
Expand Down Expand Up @@ -289,7 +290,7 @@ pub fn label_counts_over_time(rows: &[&HashMap<String, String>]) -> Chart {
chart = chart.series(
Bar::new()
.name(label.as_str())
.data(vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(vals.to_vec())
.item_style(ItemStyle::new().color(color(c))),
);
}
Expand All @@ -298,7 +299,8 @@ pub fn label_counts_over_time(rows: &[&HashMap<String, String>]) -> Chart {
}

/// 5. Open/closed by integration label: stacked horizontal bar chart.
/// Filters to source:/transform:/sink: labels only, sorted by total descending.
///
/// Filters to source:/transform:/sink: labels only, sorted by total descending.
pub fn open_closed_by_label(rows: &[&HashMap<String, String>]) -> Option<Chart> {
let mut pairs: Vec<(String, i64, i64)> = rows.iter()
.filter_map(|r| {
Expand Down Expand Up @@ -336,14 +338,14 @@ pub fn open_closed_by_label(rows: &[&HashMap<String, String>]) -> Option<Chart>
Bar::new()
.name("Closed")
.stack("total")
.data(closed_vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(closed_vals.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_CLOSED))),
)
.series(
Bar::new()
.name("Open")
.stack("total")
.data(open_vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(open_vals.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_OPEN))),
))
}
Expand Down Expand Up @@ -405,7 +407,7 @@ pub fn integration_trends(
chart = chart.series(
Line::new()
.name(col.as_str())
.data(vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(vals.to_vec())
.item_style(ItemStyle::new().color(color(c))),
);
}
Expand Down Expand Up @@ -573,14 +575,14 @@ pub fn unique_contributors_monthly(rows: &[&HashMap<String, String>]) -> Option<
Bar::new()
.name("New")
.stack("contributors")
.data(new_vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(new_vals.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_NEW_CONTRIBUTOR))),
)
.series(
Bar::new()
.name("Returning")
.stack("contributors")
.data(ret_vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(ret_vals.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_RETURNING_CONTRIBUTOR))),
))
}
Expand Down Expand Up @@ -625,14 +627,14 @@ pub fn unique_contributors_yearly(rows: &[&HashMap<String, String>]) -> Option<C
Bar::new()
.name("New")
.stack("contributors")
.data(new_vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(new_vals.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_NEW_CONTRIBUTOR))),
)
.series(
Bar::new()
.name("Returning")
.stack("contributors")
.data(ret_vals.iter().map(|v| *v).collect::<Vec<_>>())
.data(ret_vals.to_vec())
.item_style(ItemStyle::new().color(color(COLOR_RETURNING_CONTRIBUTOR))),
))
}
Expand Down Expand Up @@ -1074,7 +1076,7 @@ pub fn run(input_dir: &str, repo: &str, output_dir: &str, start: Option<&str>) -
} else { vec![] };

// Top 5 label columns for overlay (those that are not the standard cols)
let standard_issue_cols = ["month", "created_issues", "closed_issues"];
let _standard_issue_cols = ["month", "created_issues", "closed_issues"];
// Fixed type overlays matching Python's TYPE_OVERLAYS.
// Collects ALL matching columns per type and sums them (mirrors df[matching].sum(axis=1)),
// so repos that use both "type: bug" (label) and "Bug" (native type) get a continuous series.
Expand Down Expand Up @@ -1298,13 +1300,11 @@ pub fn run(input_dir: &str, repo: &str, output_dir: &str, start: Option<&str>) -
for entry in sorted {
let path = entry.path();
let repo_file = path.join(".repo");
if path.is_dir() && repo_file.exists() {
if let Ok(content) = fs::read_to_string(&repo_file) {
if let Some((o, n)) = content.trim().split_once('/') {
if path.is_dir() && repo_file.exists()
&& let Ok(content) = fs::read_to_string(&repo_file)
&& let Some((o, n)) = content.trim().split_once('/') {
repos_found.push((o.to_string(), n.to_string()));
}
}
}
}
}
generate_index(output_dir, &repos_found)?;
Expand Down
1 change: 1 addition & 0 deletions src/commands/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@ pub mod fetch_issues;
pub mod fetch_labels;
pub mod generate_summaries;
pub mod purge;
pub mod push_metrics;
pub mod remove_legacy_label;
pub mod workflows;
Loading