fix(chart): gate namespace creation behind createNamespace value - #82
Open
stone wants to merge 2 commits into
Open
fix(chart): gate namespace creation behind createNamespace value#82stone wants to merge 2 commits into
stone wants to merge 2 commits into
Conversation
- Namespace template now gated behind createNamespace value (default false) - Added helm.sh/resource-policy: keep annotation to preserve namespace on deletion - Fixes conflicts with helm install --create-namespace on both Helm 3 and 4 Fixes namespace deletion: helm install -n varnish-gateway varnish/varnish-gateway --create-namespace kubectl -n varnish-gateway run keepme --image=busybox -- sleep 36000 helm delete -n varnish-gateway varnish-gateway # <-- Also deletes the keepme pod Also fixes adopting a namespace: kubectl create namespace varnish-gateway-system helm install varnish-gateway oci://ghcr.io/varnish/charts/varnish-gateway --namespace varnish-gateway-system # Fails
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 71.99% 71.87% -0.12%
==========================================
Files 41 41
Lines 6716 6716
==========================================
- Hits 4835 4827 -8
- Misses 1539 1545 +6
- Partials 342 344 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- Add test fixture exercising namespace creation - Update values.schema.json with createNamespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes namespace deletion:
helm install -n varnish-gateway varnish/varnish-gateway --create-namespace kubectl -n varnish-gateway run keepme --image=busybox -- sleep 36000 helm delete -n varnish-gateway varnish-gateway # <-- Also deletes the keepme podAlso fixes adopting a namespace:
kubectl create namespace varnish-gateway-system helm install varnish-gateway oci://ghcr.io/varnish/charts/varnish-gateway --namespace varnish-gateway-system # Fails