20260821 update en utokyo wifi - #2144
Open
chihayakudo wants to merge 12 commits into
Open
Conversation
Removed Mfa100 component from Windows page.
Removed Mfa100 component from iOS page.
Removed Mfa100 component from the Android Wi-Fi page.
|
🚀 Deployed on https://deploy-preview-2144--utelecon.netlify.app |
Contributor
There was a problem hiding this comment.
対応ありがとうございます。
修正提案として、未使用のimport行の削除をお願いしたいです。合わせて/en/utokyo_wifi/_Mfa100.mdxの削除をお願いします（日本語版では削除済みです）。
そしてコメントをつけましたが、古い表現やリンク漏れの対応もお願いできると幸いです。
/utokyo_wifi/macos/の修正時のPR（#1990）も参考になると思います。（絶対リンク→相対リンクの置き換えは今回は画像をいじっていないので置いておきます）
Contributor
There was a problem hiding this comment.
"the regular ID" と古い共通IDになっているので"the 10-digit Common ID"の表記に直しましょう。
また、Preparationの部分は日本語版だとリンクになっているので、該当箇所へのリンクを追加したいです。
（ios, windowsも同様）
Contributor
There was a problem hiding this comment.
iOS版だけtitleが日本語になっているので、"Using UTokyo Wi-Fi on iPhone and iPad"のように直しておきましょう。
import行を削除する提案を受け入れました Co-authored-by: ichihara1205 <ryoya03052045@gmail.com>
breadcrumbのタイトルを日本語に変更 Preparationの部分にページ内リンクを追加 共通IDの表記を修正
Updated reference to the 'Preparation' step with a link.
Updated link in the user ID and password instructions for clarity.
Clarified the user ID and password requirements for UTokyo Wi-Fi.
Clarified that the user ID and password are not the regular UTokyo Account credentials, specifying that they are the 10-digit Common ID.
Author
|
修正完了しました。再度レビューをお願いします。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
en/utokyo_wifi/以下のwindows, iOS, androidの3つのページから
を削除しました。
「AY2024」お知らせボックスを削除するためです。