Skip to content

ci: use env vars instead of hard coded paths#8389

Open
sid-bruno wants to merge 2 commits into
usebruno:mainfrom
sid-bruno:ci/relative-path
Open

ci: use env vars instead of hard coded paths#8389
sid-bruno wants to merge 2 commits into
usebruno:mainfrom
sid-bruno:ci/relative-path

Conversation

@sid-bruno

@sid-bruno sid-bruno commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Description

  • Use Large Runners for e2e
  • Change actions to point to the Github workspace instead of the hardcoded bruno path

Contribution Checklist:

  • I've used AI significantly to create this pull request
  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Walkthrough

Composite actions and Linux workflows now derive Electron chrome-sandbox from GITHUB_WORKSPACE and only change permissions when the file exists. The tests-linux E2E job also adds self-hosted and large-runner runner labels.

Changes

Electron workflow config updates

Layer / File(s) Summary
Composite action updates
.github/actions/auth/oauth1/linux/setup-feature-specific-deps/action.yml, .github/actions/ssl/linux/setup-feature-specific-deps/action.yml
The auth and ssl setup actions compute CHROME_SANDBOX from GITHUB_WORKSPACE and only run chown root and chmod 4755 when the sandbox file exists.
Workflow sandbox configuration
.github/workflows/benchmarks.yml, .github/workflows/flaky-test-detector.yml, .github/workflows/tests-linux.yml
The benchmarks, flaky-test-detector, and tests-linux sandbox steps switch to GITHUB_WORKSPACE-relative chrome-sandbox paths and guard the permission commands with a file-existence check.
Runner labels
.github/workflows/tests-linux.yml
The tests-linux E2E job changes runs-on from a single Ubuntu label to ubuntu-24.04, self-hosted, and large-runner.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • usebruno/bruno#7252: Both PRs touch the GitHub Actions chrome-sandbox ownership and permission setup.

Suggested reviewers

  • helloanoop
  • lohit-bruno
  • vijayh-bruno
  • naman-bruno

Poem

A sandbox path took a longer stroll,
Then found GITHUB_WORKSPACE to play its role.
If the file is there, permissions gleam,
And runners charge ahead in a larger stream. 🛠️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately captures the main CI change: replacing hard-coded paths with environment-variable-based paths.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant