feat(import): set yml as a default file formal accross all type of imports by sharan-bruno · Pull Request #8363 · usebruno/bruno

sharan-bruno · 2026-06-24T13:34:06Z

Jira: https://usebruno.atlassian.net/browse/BRU-3654

Description

This PR sets OpenCollection (YAML) as the default file format for the Bulk Import flow — the format selector in the Bulk Import modal now defaults to yml instead of bru, so imported collections are written as opencollection.yml unless the user explicitly switches to BRU. To cover this, it adds an e2e spec (yml-as-default-file-format.spec.ts) verifying both the UI default and that importing with the default actually writes opencollection.yml (and never bruno.json) to disk. Along the way, it adds stable data-testids to the Bulk Import modal and its format selector, and exposes matching locators in the shared test helper so the suite relies on test ids rather than CSS class selectors.

Contribution Checklist:

I've used AI significantly to create this pull request
The pull request only addresses one issue or adds one feature.
The pull request does not introduce any breaking changes
I have added screenshots or gifs to help explain the change if applicable.
I have read the contribution guidelines.
Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

Summary by CodeRabbit

New Features
- Bulk Import now defaults to YAML when exporting/importing collections (generating opencollection.yml by default).
Bug Fixes
- Improved default import behavior so collections generate the expected folder/file structure when no format is chosen, and avoid generating bruno.json in the default flow.
Tests
- Added end-to-end coverage validating the Bulk Import modal’s default “File Format” selection and confirming the generated output files and exclusions.

…ports

coderabbitai · 2026-06-24T13:34:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5e062dba-d98a-40f4-9875-1d0c339fafb3

📥 Commits

Reviewing files that changed from the base of the PR and between 01ea132 and 7ba25e2.

📒 Files selected for processing (3)

packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js
tests/import/bulk-import/yml-as-default-file-format.spec.ts
tests/utils/page/locators.ts

✅ Files skipped from review due to trivial changes (1)

tests/utils/page/locators.ts

🚧 Files skipped from review as they are similar to previous changes (2)

tests/import/bulk-import/yml-as-default-file-format.spec.ts
packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js

Walkthrough

The bulk import modal and CLI collection generation now default to yml instead of bru. The modal also gains test IDs, and a new Playwright spec validates the default selector and generated file names.

Changes

Bulk Import Default Format: bru → yml

Layer / File(s)	Summary
Default format switch in app UI and CLI `packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js`, `packages/bruno-cli/src/utils/collection.js`	The bulk import state default and the CLI fallback format both change from `bru` to `yml`.
Test ID attributes on bulk import modal `packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js`	The bulk import modal, location input, and format selector gain test identifiers.
Playwright locators and e2e spec for yml default `tests/utils/page/locators.ts`, `tests/utils/page/actions.ts`, `tests/import/bulk-import/yml-as-default-file-format.spec.ts`	Bulk import locators and a modal-opening helper are added, along with a new spec that checks the `yml` default and filesystem output.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

usebruno/bruno#6533: Changes collection import format plumbing and default handling in a closely related import flow.
usebruno/bruno#6985: Switches the default collection format to yml across collection generation and import logic.
usebruno/bruno#7017: Updates the import modal’s initial collection format state from bru to yml.

Suggested reviewers

helloanoop
lohit-bruno
bijin-bruno

Poem

.bru drifts off in a gentle breeze,
yml now settles in with ease.
The modal glows with test IDs bright,
And Playwright nods, “Yes, that looks right.”

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: switching the default import file format to YAML/YML.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

🧹 Nitpick comments (1)

tests/import/bulk-import/yml-as-default-file-format.spec.ts (1)
8-17: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Use a fixtures directory for bulk import sample files.

The test currently pulls sample inputs from ../test-data; for consistency with the E2E convention, move these assets under a fixtures path and update testDataDir accordingly.
Suggested minimal update
-  const testDataDir = path.join(__dirname, '../test-data');
+  const testDataDir = path.join(__dirname, 'fixtures');
As per path instructions, "Ensure that the fixtures like the collections are nested inside the fixtures folder".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@tests/import/bulk-import/yml-as-default-file-format.spec.ts` around lines 8 -
17, Move the bulk import sample inputs out of the test-data location and point
the test to a fixtures directory instead, following the E2E convention that
collections and sample assets live under fixtures. Update the testDataDir setup
in yml-as-default-file-format.spec.ts so openBulkImportModal and any other
import helpers resolve sample-postman.json and sample-insomnia.json from the new
fixtures path, and keep the existing helper names unchanged so the rest of the
test remains intact.
Source: Path instructions

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@tests/import/bulk-import/yml-as-default-file-format.spec.ts`:
- Around line 8-17: Move the bulk import sample inputs out of the test-data
location and point the test to a fixtures directory instead, following the E2E
convention that collections and sample assets live under fixtures. Update the
testDataDir setup in yml-as-default-file-format.spec.ts so openBulkImportModal
and any other import helpers resolve sample-postman.json and
sample-insomnia.json from the new fixtures path, and keep the existing helper
names unchanged so the rest of the test remains intact.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 672008de-959b-476a-94ac-1d3f68bfb23a

📥 Commits

Reviewing files that changed from the base of the PR and between 7765320 and eca062e.

📒 Files selected for processing (4)

packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js
packages/bruno-cli/src/utils/collection.js
tests/import/bulk-import/yml-as-default-file-format.spec.ts
tests/utils/page/locators.ts

vijayh-bruno · 2026-06-26T10:45:18Z

  const [applyToCollection, setApplyToCollection] = useState(false);
  const [groupingType, setGroupingType] = useState('tags');
-  const [collectionFormat, setCollectionFormat] = useState('bru');
+  const [collectionFormat, setCollectionFormat] = useState('yml');


we have 'yml' set as a constant for default format- https://github.com/usebruno/bruno/blob/main/packages/bruno-filestore/src/constants.ts

use that instead of hardcoding. Do this everywhere

feat(import): set yml as a default file formal accross all type of im…

eca062e

…ports

sharan-bruno requested review from bijin-bruno, helloanoop, lohit-bruno, naman-bruno, sid-bruno, utkarsh-bruno and vijayh-bruno as code owners June 24, 2026 13:34

pull-request-size Bot added the size/M label Jun 24, 2026

coderabbitai Bot reviewed Jun 24, 2026

View reviewed changes

sharan-bruno changed the title ~~feat(import): set yml as a default file formal accross all type of im…~~ feat(import): set yml as a default file formal accross all type of imports Jun 24, 2026

sanish-bruno suggested changes Jun 24, 2026

View reviewed changes

Comment thread tests/import/bulk-import/yml-as-default-file-format.spec.ts Outdated

Comment thread tests/import/bulk-import/yml-as-default-file-format.spec.ts Outdated

addressed review comments

01ea132

sanish-bruno suggested changes Jun 25, 2026

View reviewed changes

Comment thread packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js Outdated

Comment thread tests/utils/page/locators.ts Outdated

Comment thread tests/import/bulk-import/yml-as-default-file-format.spec.ts Outdated

addressed review comments

7ba25e2

sanish-bruno approved these changes Jun 26, 2026

View reviewed changes

vijayh-bruno reviewed Jun 26, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(import): set yml as a default file formal accross all type of imports#8363

feat(import): set yml as a default file formal accross all type of imports#8363
sharan-bruno wants to merge 3 commits into
usebruno:mainfrom
sharan-bruno:feat/set_yml_to_default_collection_format

sharan-bruno commented Jun 24, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vijayh-bruno Jun 26, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sharan-bruno commented Jun 24, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Contribution Checklist:

Publishing to New Package Managers

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vijayh-bruno Jun 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sharan-bruno commented Jun 24, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 24, 2026 •

edited

Loading

vijayh-bruno Jun 26, 2026 •

edited

Loading