fix: remove the v4-migration legacy key from local storage

[prateek-bruno]

Description

Jira

v4-migration local storage key was introduced as a temporary migration notice for v3.5.x builds, warning them about affected APIs in their scripts.

In v4 that key becomes redundant, so this PR removes it.

Summary by CodeRabbit

• Chores
  • Cleaned up legacy storage data left over from previous application versions.

[coderabbitai]

Walkthrough

A new React hook useLegacyStorageCleanup is added that runs once on mount and removes a predefined list of legacy localStorage keys (currently only 'v4-migration'). The hook is imported and invoked inside AppProvider alongside the existing startup hooks.

Changes

Legacy localStorage Cleanup

Layer / File(s)	Summary
Hook implementation and AppProvider wiring packages/bruno-app/src/providers/App/useLegacyStorageCleanup.js, packages/bruno-app/src/providers/App/index.js	Defines useLegacyStorageCleanup with a mount-only useEffect that iterates LEGACY_STORAGE_KEYS (['v4-migration']) and calls localStorage.removeItem for each. The hook is then imported and called within AppProvider's initialization sequence.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🧹 A dusty old key, v4-migration by name,
Lingered in storage, now gone without shame.
A hook mounts just once, sweeps localStorage clean,
The tidiest startup you ever have seen.
Old ghosts begone! 👻

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and accurately describes the main change: removing the v4-migration legacy key from local storage via a new cleanup hook.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}