Skip to content

Fixes #220: Change worker exception to BaseException #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dxdc wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #220: Change worker exception to BaseException #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7abdd1
allow BaseException for worker
dxdc May 5, 2025
39da3aa
allow BaseException for worker (remaining python versions)
dxdc May 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py3.10/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion py3.11/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion py3.12/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion py3.13/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion py3.14/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion py3.9/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion pypy3.10/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion pypy3.11/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down
2 changes: 1 addition & 1 deletion pypy3.9/multiprocess/pool.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ def worker(inqueue, outqueue, initializer=None, initargs=(), maxtasks=None,
job, i, func, args, kwds = task
try:
result = (True, func(*args, **kwds))
except Exception as e:
except BaseException as e:
if wrap_exception and func is not _helper_reraises_exception:
e = ExceptionWithTraceback(e, e.__traceback__)
result = (False, e)
Expand Down