escape names interpolated into source-matching patterns - #772
Open
alhudz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: set
Baz.__name__ = r'\w+'on any class and calldill.source.getsource(Baz). It returns the source of a different class defined later in the same file. WithBaz.__name__ = 'Baz(('it raisesre.errorrather than theIOErrorthe function documents.Cause:
findsourceconcatenates__name__straight into the class-definition pattern, so a name that is not an identifier is matched as a pattern instead of literally.__name__is freely assignable and is not required to be an identifier._closuredimportbuilds its two candidate patterns fromgetname()the same way, andgetname()can return areprcontaining brackets even for ordinary objects.Fix:
re.escapethe interpolated names at the three sites.re.escapeleaves identifiers untouched, so behaviour for ordinary names is unchanged. Test added covers both the wrong-match and the uncompilable name.