Skip to content

feat(unlock-app): expose discount codes for paid locks - #16580

Open
wilber123451-design wants to merge 1 commit into
unlock-protocol:masterfrom
wilber123451-design:agent/codex/issue-16191
Open

feat(unlock-app): expose discount codes for paid locks#16580
wilber123451-design wants to merge 1 commit into
unlock-protocol:masterfrom
wilber123451-design:agent/codex/issue-16191

Conversation

@wilber123451-design

@wilber123451-design wilber123451-design commented Jul 21, 2026

Copy link
Copy Markdown

Summary

  • add a dedicated Discount Codes settings tab for paid locks
  • reuse the existing capped promo-code hook and enable it on first save
  • keep free locks on the existing settings list and disable mutations for non-managers
  • handle unsupported PublicLock versions and networks with explicit states

Prior work

This revives the approach from #16409 by @Zaid-L9 against current master. That author is credited as a co-author. This version adds read-only handling for non-managers, stricter paid-lock detection, broader tab tests, and omits unrelated changes from the prior diff.

Testing

  • node .yarn/releases/yarn-4.10.3.cjs workspace @unlock-protocol/unlock-app vitest run src/__tests__/components/interface/locks/Settings/settingsTabs.test.ts --environment=jsdom (3 tests passed)
  • node .yarn/releases/yarn-4.10.3.cjs workspace @unlock-protocol/unlock-app eslint <touched files> (0 errors)
  • git diff --check

CLA registration: #16579

Base USDC payout address: 0xd3CE8223E6b0F446a887953aF623B9c72233Ba39

@cla-bot

cla-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilber123451-design on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

@vercel

vercel Bot commented Jul 21, 2026

Copy link
Copy Markdown

@wilber123451-design is attempting to deploy a commit to the Unlock Protocol Team on Vercel.

A member of the Team first needs to authorize it.

Co-authored-by: UncleReV <Zaid-L9@users.noreply.github.com>
@cla-bot

cla-bot Bot commented Jul 21, 2026

Copy link
Copy Markdown

Thank you for your pull request and welcome to Unlock! We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @wilber123451-design on file.
In order for us to review and merge your code, please open another pull request with a single modification: your github username added to the file .clabot.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant