refactor(currency): Take CurrencyCode by value and rename Iso variant to IsoSymbol#8246
Merged
Merged
Conversation
… to IsoSymbol Address review feedback from unicode-org#8229: - Change all try_new_* constructor signatures in CurrencyFormatter to take CurrencyCode by value instead of reference (CurrencyCode is a small Copy struct). - Rename CurrencyFormatterData::Iso enum variant to IsoSymbol for clarity and symmetry with IsoName. - Add unit test coverage (test_compact_code) for both short and long compact ISO currency code formatting. TAG=agy CONV=f93d26e4-1f87-41f6-88d1-9069dadd73ee
robertbastian
approved these changes
Jul 21, 2026
robertbastian
enabled auto-merge (squash)
July 21, 2026 15:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address review feedback left on #8229 from @robertbastian:
try_new_*constructor signatures inCurrencyFormatterto takeCurrencyCodeby value instead of by reference (CurrencyCodeis a smallCopystruct).CurrencyFormatterData::Isoenum variant toIsoSymbolfor clarity and symmetry withIsoName.test_compact_code) for both short and long compact ISO currency code formatting.Changelog
N/A