refactor(currency): Split currency symbols from essential patterns#8228
Draft
younies wants to merge 1 commit into
Draft
refactor(currency): Split currency symbols from essential patterns#8228younies wants to merge 1 commit into
younies wants to merge 1 commit into
Conversation
Separate symbol mappings (placeholders, pattern configurations, and default pattern selection) into a dedicated CurrencySymbolsV1 marker and struct (symbols.rs), leaving CurrencyEssentialsV1 purely for core layout rules (patterns and indices). - Create CurrencySymbolsV1 with pattern_config_map, placeholders, and default_pattern_config in components/experimental/src/dimension/provider/currency/symbols.rs. - Extract CurrencySymbolsV1 in provider/source/src/currency/symbols.rs from CLDR (symbol and symbol-narrow). - Update CurrencyEssentialsV1 in essentials.rs to only retain patterns and indices. - Update CurrencyFormatterData::Essential and formatters in formatter.rs & compact_formatter.rs to require and use both CurrencyEssentialsV1 and CurrencySymbolsV1. - Update provider registry (provider/registry/src/lib.rs) and regenerate test and baked data for CurrencySymbolsV1 and CurrencyEssentialsV1. TAG=agy CONV=d044eeab-1ec7-4391-9cf0-a6d3d9e6edf0
younies
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate symbol mappings (placeholders, pattern configurations, and default pattern selection) into a dedicated CurrencySymbolsV1 marker and struct (
symbols.rs), leaving CurrencyEssentialsV1 purely for core layout rules (patternsandindices).Changelog
CurrencySymbolsV1withpattern_config_map,placeholders, anddefault_pattern_configincomponents/experimental/src/dimension/provider/currency/symbols.rs.CurrencySymbolsV1inprovider/source/src/currency/symbols.rsfrom CLDR (symbolandsymbol-narrow).CurrencyEssentialsV1inessentials.rsto only retainpatternsandindices.CurrencyFormatterData::Essentialand formatters informatter.rs&compact_formatter.rsto require and use bothCurrencyEssentialsV1andCurrencySymbolsV1.provider/registry/src/lib.rs) and regenerate test and baked data forCurrencySymbolsV1andCurrencyEssentialsV1.TAG=agy
CONV=d044eeab-1ec7-4391-9cf0-a6d3d9e6edf0