Allow the guide page to be rendered in 'embedded' mode.#1769
Open
FrenjaminBanklin wants to merge 2 commits into
Open
Allow the guide page to be rendered in 'embedded' mode.#1769FrenjaminBanklin wants to merge 2 commits into
FrenjaminBanklin wants to merge 2 commits into
Conversation
…r the header according to its value.
clpetersonucf
requested changes
Jul 10, 2026
clpetersonucf
left a comment
clpetersonucf
left a comment
Member
There was a problem hiding this comment.
waitForWindow only resolves when all the props passed in are present in the window object OR 10 seconds has elapsed. This appears to defer rendering of the guide page in Materia proper for 10 seconds, since IS_EMBEDDED is not present. Should be as easy as passing "IS_EMBEDDED": False in the WidgetGuideView as an additional js global.
…ide page loads don't take ten seconds to resolve.
Contributor
Author
|
Somehow didn't occur to me to make sure the new thing didn't ruin anything in Materia itself on top of working properly in the MWDK. Fix was as easy as suggested, though. Good call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1768.
Adds a check for
window.IS_EMBEDDEDdoes not render the header if it's set totrue.See ucfopen/Materia-Widget-Dev-Kit#166.