Skip to content

fixed submodule added with ssh - while all others with https - #2366

Open
rasmus-madsen wants to merge 1 commit into
ucb-bar:mainfrom
rasmus-madsen:fix_submodule
Open

rasmus-madsen wants to merge 1 commit into
ucb-bar:mainfrom
rasmus-madsen:fix_submodule

Conversation

@rasmus-madsen

@rasmus-madsen rasmus-madsen commented Aug 7, 2026 •

Copy link
Copy Markdown

When the software2026 was added as a submodule is was done with ssh, this differs from all other submodules, which are added with https.
and adds a requirement to the user to add a key for Github.

I think we should keep the submodules the same style.
also it is not really convinient to have to add a key to every machine one wants to add chipyard to

Related PRs / Issues:

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • RTL change
  • Software change (RISC-V software)
  • Build system change
  • Other

Contributor Checklist:

  • Did you set main as the base branch?
  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • Did you mark the PR with a changelog: label?
  • (If applicable) Did you update the conda .conda-lock.yml file if you updated the conda requirements file?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you add a test demonstrating the PR?
  • (If applicable) Did you mark the PR as Please Backport?

CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See ci:* for full list of labels:

  • ci:fpga-deploy - Run FPGA-based E2E testing
  • ci:local-fpga-buildbitstream-deploy - Build local FPGA bitstreams for platforms that are released
  • ci:disable - Disable CI

@jimfangx
jimfangx self-requested a review September 1, 2026 01:25
@jimfangx

jimfangx commented Sep 1, 2026

Copy link
Copy Markdown
Member

Hi @rasmus-madsen thanks for the PR - can you just update the .gitmodules? We will bump all the other modules before the next release in order not to introduce unnecessary possible breaking changes into the main repo. thanks!

@rasmus-madsen

Copy link
Copy Markdown
Author

@jimfangx sure, I already did locally, this was just to fix it globally.
do you want to keep the PR, or should I take it down?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants