Skip to content

Simplify CI workflow by removing LintConfig #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Avantol13 merged 3 commits into from
Mar 30, 2026
Merged

Simplify CI workflow by removing LintConfig #59

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bcaaba
Simplify CI workflow by removing LintConfig
Avantol13 Mar 30, 2026
9511e36
Remove dependency on LintConfig for RequiredLint job
Avantol13 Mar 30, 2026
a9994e4
fix(pre-commit): use https instead of git for compatibility
Avantol13 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,26 +23,10 @@ jobs:
python-version: '3.13'
use-cache: true

# this creates linter settings and uploads to an artifact so the configs can be pulled and used across jobs
LintConfig:
name: Get Lint Config
uses: uc-cdis/.github/.github/workflows/lint-create-config.yaml@master
with:
python-module-name: "gen3Dictionary"

RequiredLint:
name: Run Required Linters
needs: [ LintConfig ]

@nss10 nss10 Mar 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs: []

uses: uc-cdis/.github/.github/workflows/required_lint_check.yaml@master
with:
python-version: '3.13'
use-cache: true

InformationalLint:
name: Run Informational Linters
needs: [ LintConfig ] #TODO Add UnitTest
if: github.ref != 'refs/heads/main'
uses: uc-cdis/.github/.github/workflows/optional_lint_check.yaml@master
with:
python-version: '3.13'
use-cache: true