Make request header read buffer size configurable (fixes 431 Request Header Fields Too Large) - #173
Open
neverlless wants to merge 1 commit into
Open
Conversation
Fiber's default ReadBufferSize of 4096 bytes causes mokey to reject requests with 431 Request Header Fields Too Large when clients send large cookies (common when mokey is served on a domain shared with other applications) or when auth proxies add sizable headers. Add a server.read_buffer_size config option wired to fiber.Config.ReadBufferSize and raise the default to 16384. Fixes #122
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fiber's default
ReadBufferSizeis 4096 bytes, so mokey rejects any request whose headers exceed 4KB with 431 Request Header Fields Too Large:This happens easily when mokey runs on a (sub)domain shared with other applications that set large cookies, or behind auth proxies that add sizable headers. Reported in #122.
Fix
server.read_buffer_sizeconfig option wired tofiber.Config.ReadBufferSize, defaulting to 16384.mokey.toml.sample.Testing
Deployed in production behind Traefik where users' shared-domain cookies previously triggered 431s. Verified in the running container:
Fixes #122