[Intl] Add format_list filter using PHP 8.5's IntlListFormatter#4852
Open
BreyndotEchse wants to merge 3 commits into
Open
[Intl] Add format_list filter using PHP 8.5's IntlListFormatter#4852BreyndotEchse wants to merge 3 commits into
BreyndotEchse wants to merge 3 commits into
Conversation
stof
reviewed
Jul 1, 2026
fabpot
requested changes
Jul 4, 2026
fabpot
left a comment
fabpot
left a comment
Contributor
There was a problem hiding this comment.
It looks good to me.
Can you add a new doc/filters/format_list.rst file (see doc/filters/format_number.rst for an example), update doc/filters/index.rst to add format_list to the list and in extra/intl-extra/README.md?
Also, can you add an entry in CHANGELOG.md?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
format_listTwig filter to IntlExtension that formats arrays using using PHP 8.5's IntlListFormatterOn PHP < 8.5, using the filter throws a RuntimeError explaining the dependency on IntlListFormatter (Checks if
class_existsto allow polyfills).CI workflow only covered up to PHP 8.4, so I extended it to also run PHPUnit against 8.5.
phpstan's PHP version also bumped to 8.5.