Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #8231.
Add
closeAriaLabeltoNDialoganduseDialogoptions so applications can provide a localized accessible name for the default close button. It defaults tocloseand can be updated reactively. The existing custom close slot keeps its behavior.The main-branch button already has the English label
close; this addresses the issue's request for a supported way to customize that label. Both API documentation languages and changelogs are updated.Validation:
useDialogkeeparia-label="close"instead of the supplied name.Tests used Node 24.21.0, Vue 3.5.44, and Vitest 4.1.12 in a small isolated dependency environment. The test config retains the repository's classic
hJSX transform, jsdom, andsrc/vitest-setup.ts; it omits the docs plugins and JSX Vapor plugin because the latter fails at startup on Windows with afile:///vue-jsx-vapor/vdomresolution error. The full defaultpnpm testcommand and browser/screen-reader acceptance have not been verified. Dependency auto-install was set to warn locally while running the normal commit hook; that local setting is not included in the PR.Prepared with AI assistance.