Repository navigation
fix(demos): resolve vue-tsc template scope errors - #8243
Open
zha-ji-tui wants to merge 1 commit into
Open
zha-ji-tui wants to merge 1 commit into
zha-ji-tui wants to merge 1 commit into
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8243 +/- ##
==========================================
- Coverage 63.55% 63.53% -0.03%
==========================================
Files 878 878
Lines 27487 27487
Branches 8750 8750
==========================================
- Hits 17469 17463 -6
- Misses 9803 9809 +6
Partials 215 215 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Sepush
added a commit
to Sepush/naive-ui
that referenced
this pull request
Oct 25, 2026
Same change as tusen-ai#8243, so the docs lint job passes.
Sepush
added a commit
that referenced
this pull request
Oct 25, 2026
* docs: keep the theme out of the site URL The theme is the reader's preference, not part of the page, so the site no longer puts it in the path (/zh-CN/os-theme/...). - Store the choice in localStorage; by default follow the OS - Pick light, dark or follow-system from a menu in the header - Apply the theme before the first paint so a reload doesn't flash - Sync the theme across open tabs - Redirect old /:lang/(light|dark|os-theme)/... links to /:lang/... * docs: set only color-scheme before the first paint Write the inline script in current syntax and drop the hard-coded dark background: color-scheme alone gives the page a dark canvas until the styles load. * docs: move the site theme into a useColorMode composable Shaped after VueUse's useColorMode: mode is light, dark or auto (follow the OS), state is the theme in effect. It stores only an explicit pick, syncs across tabs, keeps color-scheme on <html> in step, and turns transitions off while the colors change so the page switches in one step. * fix(demos): resolve vue-tsc template scope errors Same change as #8243, so the docs lint job passes.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/image/demos/*/component-preview-group.demo.vueandsrc/avatar/demos/*/lazy.demo.vueinto<script setup>constants.lint (24)job onmain, which fails withTS1005: ":" expectedandTS2304: Cannot find namein these demos with the current TypeScript 6 + vue-tsc toolchain.The same lint failure exists on
main(8b24921), so it is unrelated to any feature PR.Test Plan
pnpm run lintpasses locally (includinglint:code,lint:src-typeandlint:demo-type).No changelog entry since there is no user-facing change.