Repository navigation
Conversation
This was referenced Sep 27, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VM host assumes identical target/scratch capacities and has no way to bind a smaller profile to the image and helper that proved it. This change validates separate helper minimums and prepares an explicit experiment selector bound to the exact immutable image reference and signed runtime-manifest SHA256.
Legacy
minimumDiskBytesstill applies to both disks. Explicit minimums must occur together, and any legacy fallback must be conservative. Missing/null/invalid bounds, duplicate keys, unsupported versions, insufficient space and overflow fail before disk creation.Production remains at 40 GiB target + 40 GiB scratch + 8 GiB Windows reserve. The approved experiment registry is empty and the build-time experiment ID defaults to empty. A wrong image, changed runtime, unknown ID or incompatible helper is rejected; lower helper minimums alone never reduce the profile. Selected capacities and their profile/runtime identity are recorded durably, with matching generated DTOs.
Validation: Go race suite; Windows cross-compilation; native Windows parser/admission evidence; exact-boundary and one-byte-short tests; malformed contract and identity rejection tests; actual child writes before low-space cancellation while its lease is retained through reap. Removing admission, swapping bounds, or removing image binding makes the corresponding tests fail.
The experiment plan and read-only fixture inventory are included. The 32/16 GiB control and separate image-specific 32/8 candidate need guest provisioning, desktop/persistence, physical-capacity and Windows evidence. No profile is activated by this PR.
Stacked on #418. Existing signed archives remain unchanged. No new Windows VM writer starts until guest measurements pass and cluster storage supports the trial above its 26 GiB guard.