Skip to content

ci: pin actions and reusable workflows to verified releases - #241

Closed
thatguywob wants to merge 1 commit into
tuna-os:mainfrom
thatguywob:sec/212-pin-workflows
Closed

thatguywob wants to merge 1 commit into
tuna-os:mainfrom
thatguywob:sec/212-pin-workflows

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Closes #212

Pin all 12 action and reusable workflow references in the five affected workflows to full commit SHAs, with version comments for updates. Resolve action pins from publisher release tags: checkout v7.0.1, upload-artifact v7.0.2, rust-cache v2.9.3, Flatpak v6.8, and action-gh-release v3.0.3. Both shared workflows use tuna-os/.github commit f835d4a4cdb18746e9b8abbc07defcef796a30a1; their caller interfaces were checked at that revision.

GitHub release metadata confirms the existing v7/v3 majors are current; the issue's suggested v4/v2 downgrades are stale. Flatpak v6.8 remains the latest release. Pinning the shared workflows does not freeze their own transitive references; those remain owned by tuna-os/.github.

Validation: parsed every workflow with PyYAML, verified all 12 references have 40-character SHA pins, and compared parsed workflow structures to confirm only reference versions changed. Schema-copy checks and git diff --check passed. Rust build/test/clippy checks were not run: this environment has no Cargo and the change touches only workflow references. actionlint was unavailable; its download was blocked by the environment's command allowlist.

— hive: backend=codex model=gpt-6.1-sol


🐝 Hive Agent: contributor | SHA: unknown

Resolve current release tags to immutable commits across the five workflows. Retain current supported majors rather than applying the stale downgrade suggestions in tuna-os#212.

Hive-Run: tuna-os#212
Hive-Plan: update-and-pin-workflow-references
Hive-Spec: issue-212#recommendation-1-2
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@hanthor

hanthor commented Oct 23, 2026

Copy link
Copy Markdown
Member

/hive approve

I checked every pin in this diff against the upstream tags with git ls-remote. For annotated tags the commit is the peeled ^{} object, and every pin here is that commit: actions/checkout v7.0.1 = 3d3c42e5, Swatinem/rust-cache v2.9.3 = d1527c8f, flatpak-github-actions v6.8 = 79327416, softprops/action-gh-release v3.0.3 = efb35369, actions/upload-artifact v7.0.2 = cf430e03, tuna-os/.github main = f835d4a4. This is the one of the five open pinning PRs I am keeping.


Generated by Claude Code

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor
e0996e2

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @thatguywob, head e0996e25cf63) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 5 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • .github/workflows/ci.yml
    • .github/workflows/flatpak.yml
    • .github/workflows/publish-flatpak.yml
    • .github/workflows/screenshots.yml
    • .github/workflows/ste.yml

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@j1mc

j1mc commented Oct 29, 2026

Copy link
Copy Markdown

This PR also covers #200: it pins all 12 current workflow references to commit SHAs. A maintainer can add Closes #200 to the PR body if the issue should close automatically on merge.

— hive: backend=pi model=openrouter/openai/gpt-6.1-terra


🐝 Hive Agent: contributor | SHA: unknown

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

17 similar comments
@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

2 similar comments
@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor-hive-agent

Copy link
Copy Markdown
Contributor

/hive approve cannot enable an automerge lane for this PR. A maintainer must merge it manually after checking the remaining requirements.

@hanthor

hanthor commented Oct 31, 2026

Copy link
Copy Markdown
Member

Sentinel reviewed (hanthor): the diff is benign (it pins third-party actions to verified release SHAs). It duplicates #232, which I've rebased and am landing. Two changes are not taken:

Closing as a duplicate. Thank you!

@hanthor

hanthor commented Oct 31, 2026

Copy link
Copy Markdown
Member

Maintainer decision (supersedes my earlier @main rationale): cross-repository workflows/actions must use immutable full commit SHAs under the newer enforced org policy (.github#288/#335); the same-repository exemption does not apply to dualcut calling tuna-os/.github. The WORKFLOWS.md @main guidance I previously cited was stale and is being corrected centrally. Sorry for the conflicting guidance.

One corrective PR, #250, now pins both org reusable workflows to the centrally reviewed fded0603d7e383990e8259141419fe6c1d641f41 snapshot. Existing permissions, inputs and token mappings are unchanged. Full workflow-pin tests (29), the actual checker against all dualcut workflows, and actionlint on both changed files passed. Merge still requires green CI. The original duplicate/obsolete PRs remain closed; #250 is the single implementation path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] Update outdated GitHub actions and pin reusable workflow references

3 participants