fix: docs/config templates upstream - #219
Open
SeriousCoding789 wants to merge 5 commits into
Open
Conversation
SeriousCoding789
force-pushed
the
docs/config-templates-upstream
branch
from
August 20, 2026 05:38
756aecb to
2b9c198
Compare
…files The mainnet and Nile HOCON templates at the repository root are mirrors of files owned by java-tron and nile-testnet. Describe those upstream files as the place to get them, and drop the promise that this repo keeps copies at its root, so the mirrors can be removed. The rendering path is unaffected: the templates the CLI renders from are the embedded copies under internal/render/templates, which stay. - README.md: rewrite the heads-up, the workflow table, the template-user note and the Configuration Templates section - Makefile: sync-templates now fetches straight into the embedded template dir instead of writing a root copy first - cmd/apply.go, cmd/network/create.go: probe the on-disk template dir with private_net_config.conf, which is maintained here, instead of main_net_config.conf
templates/ held symlinks into the root copies of the mainnet and Nile configs. Those root copies are going away, which would leave the links dangling and make the directory probe in apply and network create reject the whole directory. Remove the two links; private_net_config.conf still points at the copy maintained here. Rendering is unaffected: mainnet and Nile now resolve to the embedded templates under internal/render/templates.
main_net_config.conf and test_net_config.conf were copies of files owned by java-tron and nile-testnet. Take them out of the repository root; the templates the CLI renders from are the embedded copies under internal/render/templates, which keep their names and are refreshed from upstream by `make sync-templates`. private_net_config.conf is unaffected — it has no upstream and is still maintained here, at the root and through the templates/ symlink. - delete main_net_config.conf, test_net_config.conf - internal/render/hocon.go: note where the templates now live - README.md: keep the historical template name in the workflow table
findTemplatesDir keyed off one hardcoded filename, so a directory that carried only the other networks' templates was rejected outright and the override silently fell back to the embedded copies. Walk the known templates instead and accept the directory as soon as one of them is there. Both copies of the helper, in apply and in network create, had the same check.
SeriousCoding789
force-pushed
the
docs/config-templates-upstream
branch
from
August 20, 2026 07:17
2b9c198 to
d0d6a27
Compare
warku123
reviewed
Aug 24, 2026
warku123
reviewed
Aug 24, 2026
…README template references
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The mainnet and Nile HOCON templates at the repository root are mirrors of files owned by java-tron and nile-testnet. Describe those upstream files as the place to get them, and drop the promise that this repo keeps copies at its root, so the mirrors can be removed.
Why are these changes required?
This PR has been tested by:
Follow up
Extra details