fix(screen): C-side screen:get_bounding_geometry parity with old lua functionality - #646
Draft
notFoxils wants to merge 2 commits into
Draft
fix(screen): C-side screen:get_bounding_geometry parity with old lua functionality#646notFoxils wants to merge 2 commits into
screen:get_bounding_geometry parity with old lua functionality#646notFoxils wants to merge 2 commits into
Conversation
summary:
- Ran `nix flake update`
notes:
- The project wouldn't build previously because the lockfile pointed
to a nixpkgs revision before the wlroots was updated to 0.19.3.
summary:
- `luaA_screen_get_bounding_geometry`
Apply the margin-based geometry adjustments like was done before
in the lua function `screen.object.get_bounding_geometry`.
notes:
- `luaA_screen_get_bounding_geometry`
The function is still missing padding adjustments I want to talk
before I make these changes as I believe it need an additional
field in screen_t and getters/setters for that field.
The documentation above the function probably needs adjustment.
Contributor
|
I guess this then also applies to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
luaA_screen_get_bounding_geometryApply the margin-based geometry adjustments like was done before
in the lua function
screen.object.get_bounding_geometry.Test Plan
Tested with obnoxious useless_gap sizes in the theme and checking that the column, gap, and margin sizes are consistent.
Checklist
lua/awful/,lua/gears/,lua/wibox/,lua/naughty/) are not modified — if a bug surfaces in Lua, the fix belongs in Cmake test-unit && make test-integration)Notes
The function is still missing padding adjustments I want to talk
before I make these changes as I believe it need an additional
field in screen_t and getters/setters for that field.
The documentation above the function probably needs adjustment.