Repository navigation
Lift records with a plain mapK on fs2-kafka 4.1.2 - #299
Merged
Merged
Conversation
fs2-kafka 4.1.2 (typelevel/fs2-kafka#1531) makes a committer produced by `KafkaCommitter#mapK` equal to the committer it was derived from, so `CommittableOffsetBatch` merges lifted offsets again. `injectK` no longer needs to cache one lifted committer per consumer, and the `fs2.kafka.LiftedCommittableOffset` shim that rebuilt offsets around the cached committer goes with it. 4.1.2 also fixes the deadlock on `KafkaConsumer#unsubscribe` once partitions are assigned (typelevel/fs2-kafka#1530).
github-actions
Bot
added
📦 refactor
Oliver-Taylor
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs2-kafka 4.1.2 ships typelevel/fs2-kafka#1531, which makes a committer produced by
KafkaCommitter#mapKequal to the committer it was derived from, soCommittableOffsetBatchmerges lifted offsets again. With that,injectKgoes back to a plainmapKper record: the per-committer cache from #297 and thefs2.kafka.LiftedCommittableOffsetshim are removed.4.1.2 also fixes a deadlock on
KafkaConsumer#unsubscribeonce partitions are assigned (typelevel/fs2-kafka#1530), which affected every consumer released throughunsubscribeon 4.1.0 and 4.1.1.The batching test added in #297 is unchanged and keeps passing, now against fs2-kafka's own behaviour.