Repository navigation
Restore the consumer.group span attribute - #298
Merged
Merged
Conversation
fs2-kafka 4 removed `CommittableOffset#consumerGroupId`, so the migration in #293 dropped the `consumer.group` attribute from `kafka.receive` spans. The group id is still reachable through `KafkaCommitter#metadata`, which calls the blocking `groupMetadata()` on the underlying consumer, so it is fetched once per committer and cached for the rest of the stream. A failing fetch (no `group.id` configured) falls back to an empty string, as before.
github-actions
Bot
added
🚀 feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs2-kafka 4 removed
CommittableOffset#consumerGroupId, so #293 dropped theconsumer.groupattribute fromkafka.receivespans.This brings it back through
KafkaCommitter#metadata. Since that calls the blockinggroupMetadata()on the consumer, the group id is fetched once per committer and cached for the rest of the stream. A failing fetch (nogroup.idconfigured) falls back to an empty string, matching the pre-4.0 behaviour.injectkeeps itsFunctor[G]bound, the caching runs inF.injectKis unchanged.Includes a test asserting the attribute is set on every record and the metadata is fetched a single time.