Skip to content

Update fs2-kafka to 4.1.0 #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scala-steward wants to merge 1 commit into from
Closed

Update fs2-kafka to 4.1.0 #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/trace4cats-kafka-client/src/main/scala/trace4cats/kafka/TracedConsumer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ object TracedConsumer extends Fs2StreamSyntax {
}

// Lifting the stream into `G` means rebuilding each record's `CommittableOffset` in `G`, and
// fs2-kafka 4.0.0 made that constructor package-private. Uncomment and release as soon as
// fs2-kafka 4.1.0 made that constructor package-private. Uncomment and release as soon as
// https://github.com/typelevel/fs2-kafka/pull/1522, which adds `mapK`, is merged and released.
//
// def injectK[F[_]: MonadCancelThrow, G[_]: MonadCancelThrow: Trace, K, V](
Expand Down
2 changes: 1 addition & 1 deletion modules/trace4cats-kafka-client/src/main/scala/trace4cats/kafka/TracedProducer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import trace4cats.TraceHeaders

object TracedProducer {

// fs2-kafka 4.0.0 folded the transactional methods into `KafkaProducer`, and two of them cannot
// fs2-kafka 4.1.0 folded the transactional methods into `KafkaProducer`, and two of them cannot
// be implemented by a wrapper: `withSerializers` takes serializers in `G` and
// `produceAndCommitTransactionally` takes offsets in `G`, both of which have to reach a producer
// running in `F`. Uncomment and release as soon as
Expand Down
Loading