docs(changelog): record the MSRV bump to 1.64.0 in 0.5.0#877
Open
ameyypawar wants to merge 1 commit into
Open
Conversation
The 0.5.0 changelog documents only tower-rs#741's bump to 1.63.0, but tower-rs#778 ("use workspace dependencies") raised `rust-version` to 1.64.0 in the same release cycle (it ships in tower-0.5.0). `tower/Cargo.toml` has read 1.64.0 ever since while the changelog still recorded 1.63.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #785.
tower/Cargo.tomlhasrust-version = "1.64.0", but the CHANGELOG's last MSRV note (in the 0.5.0 section) only records the bump to 1.63.0 from #741.Tracing the history, the 1.64.0 bump happened in the same 0.5.0 cycle but went undocumented: #741 raised MSRV to 1.63.0, and then #778 ("use workspace dependencies", commit
85080a5) raisedrust-versionto 1.64.0. That commit is contained in thetower-0.5.0tag, andrust-versionhas stayed at 1.64.0 ever since.This adds the missing entry to the 0.5.0 changelog (keeping the existing #741/1.63.0 line, since both bumps really happened that cycle):
- **MSRV**: Increase MSRV to 1.63.0 ([#741]) + - **MSRV**: Increase MSRV to 1.64.0 ([#778])plus the corresponding
[#778]link reference. CHANGELOG-only change.(For reference, #792 — "relax MSRV to 1.63" — was closed without merging, so documenting 1.64.0 matches the intended MSRV rather than reverting it.)