Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tower/src/steer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -113,9 +113,17 @@ pub struct Steer<S, F, Req> {
impl<S, F, Req> Steer<S, F, Req> {
/// Make a new [`Steer`] with a list of [`Service`]'s and a [`Picker`].
///
/// # Panics
///
/// Panics if the `services` collection is empty
///
/// Note: the order of the [`Service`]'s is significant for [`Picker::pick`]'s return value.
pub fn new(services: impl IntoIterator<Item = S>, router: F) -> Self {
let services: Vec<_> = services.into_iter().collect();
assert!(
!services.is_empty(),
"steer must contain at least one service"
);
let not_ready: VecDeque<_> = services.iter().enumerate().map(|(i, _)| i).collect();
Self {
router,
Expand Down
12 changes: 12 additions & 0 deletions tower/tests/steer/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,15 @@ async fn pending_all_ready() {
),
}
}
#[test]
#[should_panic(expected = "steer must contain at least one service")]
fn steer_new_zero_services_panics() {
use std::iter::empty;
use tower::steer::Steer;
use tower::util::BoxService;

let empty_services = empty::<BoxService<(), (), tower::BoxError>>();

// Explicitly annotate the Request type as () so inference succeeds
let _: Steer<_, _, ()> = Steer::new(empty_services, |_: &()| 0);
}