fix(browser): preserve funnel history in StrictMode - #185
Open
chungyo wants to merge 1 commit into
Open
Conversation
React StrictMode replays effects in development, causing cleanup to remove the persisted step, context, and histories after a reload. Restore the snapshot only when the same mounted funnel reconnects, while keeping cleanup synchronous for real unmounts. Refs toss#170
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
React Strict Mode replays effects with an extra setup-cleanup-setup cycle in development. The browser adapter cleanup removes the funnel step from the URL and its context and histories from
history.state, so the current screen survives the first reload while its persisted state is lost. A second reload then resets the funnel to its initial step.Closes #170.
What changed
history.stateentry as a compare-and-swap guard, so another navigation or state update is never overwritten.Verification
pnpm --filter @use-funnel/browser exec vitest run(6 passed)pnpm --filter @use-funnel/browser build