Skip to content

Chore(deps): Allow for updating parking_lot - #8745

Open
PaulDance wants to merge 1 commit into
tokio-rs:masterfrom
PaulDance:deps/update-parkinglot
Open

PaulDance wants to merge 1 commit into
tokio-rs:masterfrom
PaulDance:deps/update-parkinglot

Conversation

@PaulDance

@PaulDance PaulDance commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This udpates parking_lot to 0.13.0. In order to avoid having to bump
the MSRV to 1.95.0 as well, the requirement is relaxed to support either
0.12 or 0.13. This should work well because the only breaking changes
are the removal of functions like const_mutex and their uses are
removed from here too while 0.12 already supports their regular
equivalents such as Mutex::new in const contexts.

Doing this requires pinning the dependency in some CI jobs to ensure it
does not upgrade to 0.13 there by accident. Other jobs use the latest
stable toolchain, so they can use 0.13 and thus cover that version too.

This is effectively a retry of #8738.

@PaulDance
PaulDance force-pushed the deps/update-parkinglot branch 3 times, most recently from 13f5a8f to 9debbe0 Compare October 30, 2026 20:06
@Darksonn Darksonn added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate A-tokio-util Area: The tokio-util crate A-tokio-stream Area: The tokio-stream crate A-ci Area: The continuous integration setup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2026
@PaulDance
PaulDance force-pushed the deps/update-parkinglot branch 4 times, most recently from cf472bc to 9836a69 Compare October 30, 2026 22:51
This udpates `parking_lot` to 0.13.0. In order to avoid having to bump
the MSRV to 1.95.0 as well, the requirement is relaxed to support either
0.12 or 0.13. This should work well because the only breaking changes
are the removal of functions like `const_mutex` and their uses are
removed from here too while 0.12 already supports their regular
equivalents such as `Mutex::new` in `const` contexts.

Doing this requires pinning the dependency in some CI jobs to ensure it
does not upgrade to 0.13 there by accident. Other jobs use the latest
stable toolchain, so they can use 0.13 and thus cover that version too.

Signed-off-by: Paul Mabileau <paul.mabileau@harfanglab.fr>
@PaulDance
PaulDance force-pushed the deps/update-parkinglot branch from 9836a69 to d4e6924 Compare October 30, 2026 23:11

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ci Area: The continuous integration setup A-tokio Area: The main tokio crate A-tokio-stream Area: The tokio-stream crate A-tokio-util Area: The tokio-util crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants