Correct timestamp normalization at integer boundaries - #1458
Open
RanaPriyansh wants to merge 1 commit into
Open
RanaPriyansh wants to merge 1 commit into
RanaPriyansh wants to merge 1 commit into
Conversation
RanaPriyansh
force-pushed
the
fix/timestamp-normalization-1412
branch
from
September 24, 2026 09:45
1ea0531 to
dfef52d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1412.
Timestamp::try_normalize()can accept overflowing timestamps and reject valid values that normalize exactly to an integer boundary. Use checked arithmetic for the whole-second adjustment and Euclidean remainder for nanoseconds. Preserve the original value on failure and leave saturating normalization unchanged.Regression tests include integer boundaries and an independent integer oracle. Local
prost-typeslibrary tests passed with default features, no default features, and all features. Focused debug and release checks, strict package documentation, and workspace formatting passed on Rust 1.97.Strict package Clippy fails on an existing
question_markdiagnostic indatetime.rs. Full workspace and platform CI have not run locally.Prepared with AI assistance.