llms/anthropic: handle multiple parts in AI messages#1513
Open
Rony-ZenAlden wants to merge 1 commit into
Open
Conversation
handleAIMessage only inspected msg.Parts[0], so an assistant message containing both text and a tool call (e.g. [TextContent, ToolCall]) serialized only the first part and silently dropped the rest. This caused Anthropic API errors on the following turn because the tool_result had no corresponding tool_use block. Iterate over every part and emit a content block for each, mirroring handleHumanMessage. This also fixes a potential panic when Parts is empty (previously an out-of-range access on Parts[0]). Add unit tests covering a mixed text + tool-call message and the empty-parts case. Fixes tmc#1468 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handleAIMessage only inspected msg.Parts[0], so an assistant message containing both text and a tool call (e.g. [TextContent, ToolCall]) serialized only the first part and silently dropped the rest. This caused Anthropic API errors on the following turn because the tool_result had no corresponding tool_use block.
Iterate over every part and emit a content block for each, mirroring handleHumanMessage. This also fixes a potential panic when Parts is empty (previously an out-of-range access on Parts[0]).
Add unit tests covering a mixed text + tool-call message and the empty-parts case.
Fixes #1468
PR Checklist
memory: add interfaces for X, Yorutil: add whizzbang helpers).Fixes #123).golangci-lintchecks.