Repository navigation
fix version file generation - #2223
Merged
Merged
Conversation
✅ Deploy Preview succeeded!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for calico-docs-preview-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This commit shows the result of the new version filtering utility. A few notes: 1. `cnx-manager-proxy` and `waf-http-filter` components are added; these components were not present in the docs releases.json, but do exist. 2. `coreos-alertmanager` and `eck-elasticsearch-operator` versions were downgraded in this PR; *THIS IS NOT CORRECT*; however, I wanted to commit this result anyway to show the unmodified results. This will be fixed upstream so that the generated file will be correct. 3. Some other filtering is done; `calico-private` as a component is removed, and the `fluentd` component is renamed, to match what exists in docs already. Ideally, we should either fix these upstream or change them in docs so that we're being universally consistent.
* Update the Makefile to add targets people can use to update the existing versions present in the docs. This will not add new versions if they have been published! * Update the update-component-versions script to warn if more or less than 1 version is set as latest * Update the versions/releases files for 3.19-2. The data/versions are the same, but keys are in a different order so a large diff is present.
danudey
force-pushed
the
fix-version-file-generation
branch
from
August 14, 2025 19:58
858abdb to
2447da9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a small golang utility to filter the upstream versions file from Calico. It currently does the following:
coreos-*oreck-*imagefield to each non-ignored component which does not have one, based either on a static mapping ofcomponent name->image nameif present, or assuming the image name and component name is identical otherwise.The second commit shows the result of the new version filtering utility. A few notes on these results:
cnx-manager-proxyandwaf-http-filtercomponents are added; these components were not currently present in the docsreleases.json, but do exist as images.coreos-alertmanagerandeck-elasticsearch-operatorversions were downgraded in this PR; THIS IS NOT CORRECT; however, I wanted to commit this result anyway to show the unmodified results. This will be fixed upstream so that the generated file will be correct.calico-privateas a component is removed, and thefluentdcomponent is renamed, to match the component name used in docs already. Ideally, we should either fix these upstream or change them in docs so that we're being universally consistent.