Skip to content

fix(wasm): add replace directive for nikunjy/rules to fix semver prerelease handling - #4808

Merged
kodiakhq[bot] merged 3 commits into
mainfrom
add-replace-wasm
Feb 12, 2026
Merged

fix(wasm): add replace directive for nikunjy/rules to fix semver prerelease handling#4808
kodiakhq[bot] merged 3 commits into
mainfrom
add-replace-wasm

Conversation

@thomaspoignant

Copy link
Copy Markdown
Owner

Description

Problem: The WASM module's dependency on github.com/nikunjy/rules has semver comparison issues with prerelease versions, which can break flag evaluation in the WASM build.

Resolution: Add a replace directive in cmd/wasm/go.mod to use the fork github.com/hairyhenderson/rules (from nikunjy/rules#43) until that fix is merged and a new release is available. The go.mod is also tidied: require blocks are reorganized and github.com/blang/semver is updated to v4.

Testing: Build and test the WASM module (make build-wasm, tests in cmd/wasm). No breaking changes; this is dependency-only.

Closes issue(s)

Resolve #4736

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

…dling

Resolve #4736. Use hairyhenderson/rules fork until nikunjy/rules#43 is merged.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@netlify

netlify Bot commented Feb 12, 2026

Copy link
Copy Markdown

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 3ec34a1
🔍 Latest deploy log https://app.netlify.com/projects/go-feature-flag-doc-preview/deploys/698e16a953e8ca00086a91d1

@kodiakhq

kodiakhq Bot commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a semantic versioning issue in the WASM module by using a replace directive in go.mod to point to a forked repository. While this resolves the immediate issue, it introduces a medium-severity supply chain risk due to the use of an unofficial forked dependency. This temporary fix should be monitored and reverted once the upstream fix is available. Additionally, the PR tidies up the go.mod file, and a minor issue with the pseudo-version in the replace directive has been identified and a suggestion provided.

Comment thread cmd/wasm/go.mod
@codecov

codecov Bot commented Feb 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.75%. Comparing base (c1b2948) to head (3ec34a1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4808   +/-   ##
=======================================
  Coverage   85.75%   85.75%           
=======================================
  Files         153      153           
  Lines        6537     6537           
=======================================
  Hits         5606     5606           
+ Misses        700      699    -1     
- Partials      231      232    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@sonarqubecloud

Copy link
Copy Markdown

@kodiakhq
kodiakhq Bot merged commit a466057 into main Feb 12, 2026
24 checks passed
@kodiakhq
kodiakhq Bot deleted the add-replace-wasm branch February 12, 2026 18:11
thomaspoignant added a commit that referenced this pull request May 16, 2026
…elease handling (#4808)

* fix(wasm): add replace for nikunjy/rules to fix semver prerelease handling

Resolve #4736. Use hairyhenderson/rules fork until nikunjy/rules#43 is merged.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>

* tidy

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>

---------

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(bug) Incorrect result of semver comparison in targeting queries

1 participant