fix(wasm): add replace directive for nikunjy/rules to fix semver prerelease handling - #4808
Conversation
…dling Resolve #4736. Use hairyhenderson/rules fork until nikunjy/rules#43 is merged. Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
There was a problem hiding this comment.
Code Review
This pull request addresses a semantic versioning issue in the WASM module by using a replace directive in go.mod to point to a forked repository. While this resolves the immediate issue, it introduces a medium-severity supply chain risk due to the use of an unofficial forked dependency. This temporary fix should be monitored and reverted once the upstream fix is available. Additionally, the PR tidies up the go.mod file, and a minor issue with the pseudo-version in the replace directive has been identified and a suggestion provided.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4808 +/- ##
=======================================
Coverage 85.75% 85.75%
=======================================
Files 153 153
Lines 6537 6537
=======================================
Hits 5606 5606
+ Misses 700 699 -1
- Partials 231 232 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
…elease handling (#4808) * fix(wasm): add replace for nikunjy/rules to fix semver prerelease handling Resolve #4736. Use hairyhenderson/rules fork until nikunjy/rules#43 is merged. Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org> * tidy Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org> --------- Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>



Description
Problem: The WASM module's dependency on
github.com/nikunjy/ruleshas semver comparison issues with prerelease versions, which can break flag evaluation in the WASM build.Resolution: Add a
replacedirective incmd/wasm/go.modto use the forkgithub.com/hairyhenderson/rules(from nikunjy/rules#43) until that fix is merged and a new release is available. The go.mod is also tidied: require blocks are reorganized andgithub.com/blang/semveris updated tov4.Testing: Build and test the WASM module (
make build-wasm, tests incmd/wasm). No breaking changes; this is dependency-only.Closes issue(s)
Resolve #4736
Checklist
README.mdand/website/docs)