Repository navigation
Prevent automatic browser translation of competitor names (#305) - #306
Merged
Merged
Conversation
Fixes thewca#305. Add translate="no" attribute to competitor name variables across dialogs, tables, and lists to prevent translation engines from translating proper names.
Member
|
Thank you :) |
Contributor
Author
|
Thanks for the review and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #305
Summary of Changes
Added
translate="no"attribute and<span>wrappers to competitor name variables across the application UI to prevent browser translation engines (like Google Translate) from hallucinating translations for proper nouns.translate="no"to dialog title and name body field.translate="no"to competitor profile headers, results tables (RoundResultsTable), list items (CompetitorList), projector views (ResultsProjector), and record entries (RecordList).translate="no"across admin competitor tables, double-check forms, and dialogs.