add support for providing an own ca#602
Conversation
|
@coderabbitai review |
✅ Action performedReview finished.
|
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'd like to see some tests for this, probably very similar how we test Also, may I assume, that switching to a custom_ca will invalidate all consumer (client) certs? Sounds like lots of fun :) |
|
TBH haven't thought about switching, and yes, you are right. I will write some tests and convert this to draft, I agree that it may take some more work :) |
Why are you introducing these changes? (Problem description, related links)
Foremanctl should be able to handle user supplied CAs for signing certificates
partly fixes #297
What are the changes introduced in this pull request?
custom_ca: imports a supplied CA and uses it to sign certificates--certificate-ca-certificate,--certificate-ca-key,--certificate-ca-key-passwordHow to test this pull request
Steps to reproduce:
Checklist