Skip to content

Ensure slide diff calculation is a number #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JarredMack wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure slide diff calculation is a number #472

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfda0be
Ensure slide diff calculation is a number
JarredMack Sep 8, 2014
34b380b
Moving length init outside of setup
JarredMack Sep 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions swipe.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ function Swipe(container, options) {
// quit if no root element
if (!container) return;
var element = container.children[0];
var slides, slidePos, width, length;
var slides, slidePos, width;
var length = element.children.length;
options = options || {};
var index = parseInt(options.startSlide, 10) || 0;
var speed = options.speed || 300;
Expand All @@ -38,7 +39,6 @@ function Swipe(container, options) {

// cache slides
slides = element.children;
length = slides.length;

// set continuous to false if only one slide
if (slides.length < 2) options.continuous = false;
Expand Down Expand Up @@ -123,7 +123,7 @@ function Swipe(container, options) {

// if going forward but to < index, use to = slides.length + to
// if going backward but to > index, use to = -slides.length + to
if (direction !== natural_direction) to = -direction * slides.length + to;
if (direction !== natural_direction) to = -direction * slides.length + Number(to);

}

Expand Down