Repository navigation
feat: support tfenv use - to switch to previous version (#378) - #483
Merged
Merged
Conversation
Similar to cd -, tfenv use - now switches back to the previously active default version. The previous version is saved to \$TFENV_CONFIG_DIR/version.prev each time tfenv use writes a new default. Running tfenv use - again toggles between the two versions. If no previous version exists, the command errors with a clear message. Also adds version.prev cleanup to the cleanup() helper in lib/helpers.sh to prevent test pollution. Fixes #378
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to
cd -,tfenv use -now switches back to the previously active default version:Implementation: Before writing the new version to
$TFENV_CONFIG_DIR/version, the current version is saved toversion.prev(only when the version actually changes). When-is passed as the argument, the previous version is read fromversion.prevand used as the requested version.Changes:
libexec/tfenv-use: Handle-arg to read fromversion.prev; save current version before overwriting.lib/helpers.sh: Addversion.prevcleanup tocleanup()to prevent test pollution.test/test_use_dash.sh: New test file with two cases — toggling between versions and error on no previous version.Fixes #378