Skip to content

Remove usage of name member #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tfoote merged 1 commit into from
Mar 5, 2024
Merged

Remove usage of name member #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/ghrocker/ghpages_extension.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,9 @@

class GHPages(RockerExtension):

name = 'ghpages'

@classmethod
def get_name(cls):
return cls.name
@staticmethod
def get_name():
return 'ghpages'

def precondition_environment(self, cli_args):
pass
Expand All @@ -40,7 +38,7 @@ def get_preamble(self, cli_args):
return ''

def get_snippet(self, cliargs):
snippet = pkgutil.get_data('ghrocker', 'templates/%s_snippet.Dockerfile.em' % self.name).decode('utf-8')
snippet = pkgutil.get_data('ghrocker', 'templates/%s_snippet.Dockerfile.em' % self.get_name()).decode('utf-8')
return empy_expand(snippet, {})

def get_docker_args(self, cli_args):
Expand Down