Modernization and cleanup - #160
Merged
Merged
Conversation
- Declare rake in the Gemfile's :test group. Gemspec development dependencies land in bundler's :development group, which CI excludes via BUNDLE_WITHOUT=development, so `bundle exec rake` failed with "can't find executable rake for gem rake" - Relax dev dependency pins that require Ruby >= 3.2 (minitest 6, pry-byebug 3.12); bundler resolves the whole Gemfile even for a single group, so these broke the Ruby 3.1 matrix entry outright - kitchen-opennebula: depend on fog-opennebula instead of the fog metagem, which pulls fog-ovirt -> ovirt-engine-sdk and fails to build - guard-kitchen: read the version in the gemspec without loading the library, which requires guard and is unavailable while bundler evaluates the gemspec Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Tim Smith <tsmith84@proton.me>
tas50
force-pushed
the
ruby-3.1-ci-modernization
branch
from
August 22, 2026 06:03
3cec8bf to
06aedc6
Compare
Changelogs are produced by release-please now, so the generator task and its pinned dependency are dead weight. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Tim Smith <tsmith84@proton.me>
- Use `gemspec development_group: :test`. Gemspec development dependencies otherwise land in bundler's :development group, which CI excludes via BUNDLE_WITHOUT=development, so rspec/fakefs/rake were missing at runtime - Add base64 where cucumber 9.x needs it; it is no longer a default gem on Ruby 4.0 - kitchen-opennebula: fog-opennebula's latest release is 0.0.5, so ">= 0.1" could never resolve - kitchen-rackspace: port the driver off Kitchen::Driver::SSHBase, removed in test-kitchen 4.x, and wait via the configured transport instead Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Tim Smith <tsmith84@proton.me>
AllCops/Include pinned the file list to **/*.rb, which quietly excluded the gemspec, Gemfile and Rakefile -- cookstyle reported success while never looking at them. Dropping the Include list restores cookstyle's own defaults, which cover those files, and the offenses that surfaced are autocorrected here. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks Ruby 3.1.
minitestwas pinned to~> 6.0", "< 6.1, but minitest 6 requires Ruby >= 3.2. Bundler resolves the entire Gemfile even when a job installs only one group, so this failed the Ruby 3.1 matrix entry — and the Cookstyle job — before either got as far as running anything:Relaxed to
>= 5.0so Ruby 3.1 resolves minitest 5.x while newer Rubies still get 6.x.