fix: report this gem's own version to kitchen diagnose - #490
Merged
Conversation
`kitchen diagnose` is what a bug report is asked to include, and what it said
about this plugin was wrong in both halves:
driver:
Docker:
version: # nothing
api_version: # nothing
transport:
Docker:
version: 4.1.1 # Test Kitchen's version, not kitchen-docker's
api_version:
The transport declared `plugin_version Kitchen::VERSION`, which is Test
Kitchen's version constant, so a diagnose from kitchen-docker 3.3.4 running
under Test Kitchen 4.1.1 reported the transport as 4.1.1. The driver declared
no version at all, and `kitchen_transport_api_version` was commented out.
Both now declare this gem's version and the plugin API version they are
written against, as every plugin shipped with Test Kitchen does:
driver:
Docker:
version: 3.3.4
api_version: 2
transport:
Docker:
version: 3.3.4
api_version: 1
The values are diagnostic only -- nothing in Test Kitchen branches on them --
so this changes what is reported and nothing else.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
tas50
force-pushed
the
fix/plugin-version-metadata
branch
from
August 23, 2026 19:44
a07eac5 to
cb7ce74
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kitchen diagnoseis what bug reports are asked to include, and what it said about this plugin was wrong in both halves.Before
The transport declared
plugin_version Kitchen::VERSION— that constant is Test Kitchen's version, so a diagnose from kitchen-docker 3.3.4 running under Test Kitchen 4.1.1 reported the transport as 4.1.1. The driver declared no version at all, andkitchen_transport_api_versionwas sitting there commented out.Every plugin shipped with Test Kitchen declares both (
kitchen_driver_api_version 2,kitchen_transport_api_version 1).After
Risk
None to behaviour. Both values are diagnostic only — nothing in Test Kitchen branches on either;
api_versionis read exactly once, byConfigurable.diagnose. This changes what is reported and nothing else.Confirmation
Output above is real
kitchen diagnose --allagainst Test Kitchen 4.1.1, before and after.rake styleclean;rspec319 examples, 0 failures (6 new, including one pinning that the reported version is notKitchen::VERSION).