[release-v0.42.x] don't validate skipped task results for pipeline results - #6374
Merged
tekton-robot merged 1 commit intoMar 20, 2023
Merged
Conversation
This commit skip the validation for skipped task results in pipeline results. This fixes tektoncd#6139. The skipped task results are not emitted by design thus we shouldn't validate if they are emitted. Pipeline results referenced to skipped task will not be emitted. Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
tekton-robot
added
release-note
tekton-robot
added
the
size/M
Collaborator
|
The following is the coverage report on the affected files.
|
Collaborator
|
The following is the coverage report on the affected files.
|
lbernick
approved these changes
Mar 17, 2023
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lbernick The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pritidesai
reviewed
Mar 17, 2023
| Value: *v1beta1.NewStructuredValues("$(tasks.skippedTask.results.foo)"), | ||
| }, { | ||
| Name: "pipeline-result-2", | ||
| Value: *v1beta1.NewStructuredValues("$(tasks.skippedTask.results.foo), $(tasks.normaltask.results.baz)"), |
Member
There was a problem hiding this comment.
can I please request to add one more result:
Name: "pipeline-result-3",
Value: *v1beta1.NewStructuredValues("$(tasks.normaltask.results.baz)"),
and verify pipeline-result-3 exists in the expectedResults
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This is a cherry-pick commit of #6157.
This commit skip the validation for skipped task results in pipeline results. This fixes #6139. The skipped task results are not emitted by design thus we shouldn't validate if they are emitted. Pipeline results referenced to skipped task will not be emitted.
/kind bug
Signed-off-by: Yongxuan Zhang yongxuanzhang@google.com
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes