feat: add default StepAction catalog to Hub Resolver - #10420
Conversation
Configure git-clone-stepaction as the default Artifact Hub catalog for StepAction resources in both resolver implementations. Update the shipped ConfigMap and documentation, and cover default, missing-key, and compatibility behavior. Fixes tektoncd#10419
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
|
/kind feature |
|
/retest |
|
Follow-up: The only test failure was the |
vdemeester
left a comment
There was a problem hiding this comment.
I think the default value is wrong and we would need to create a tekton-catalog-stepactions catalog.. But with tektoncd/community#1283, these default values would quickly not make sense and be "frozen in time" even..
cc @tektoncd/core-maintainers
| # the default Artifact Hub Pipeline catalog from where to pull the resource. | ||
| default-artifact-hub-pipeline-catalog: "tekton-catalog-pipelines" | ||
| # the default Artifact Hub StepAction catalog from where to pull the resource. | ||
| default-artifact-hub-stepaction-catalog: "git-clone-stepaction" |
There was a problem hiding this comment.
It shouldn't be this one, but most likely tekton-catalog-stepactions isn't it ? But it was never created..
|
Thanks, that makes sense. I’ll hold off on changing the PR until the core maintainers confirm the intended direction; I’m also happy to close it if the default-catalog approach is no longer desired. |
|
@roian6 thanks for your understanding. I want inputs for other mainatiners about what should we do there 👼🏼 |
Changes
default-artifact-hub-stepaction-catalogwith the shipped defaultgit-clone-stepaction.catalogin both resolver implementations.Fixes #10419
Verification
go test -race -count=1 ./pkg/resolution/resolver/hub ./pkg/remoteresolution/resolver/hubmake test-unit-verbose-and-racego vet ./...golangci-lint run --modules-download-mode=vendor --new-from-rev=origin/main --max-issues-per-linter=0 --max-same-issues=0 --timeout=10m(0 issues)./hack/verify-codegen.sh(up to date)yamllint -c .yamllint config/resolvers/hubresolver-config.yaml./hack/verify-agent-readiness.shpre-commit run --all-filesruns all unit tests successfully, but its full-repository lint/private-key hooks are currently blocked by existingorigin/mainfindings: thedocs/auth.mdtest fixture is detected as a private key and full lint reports 161 issues on both cleanorigin/mainand this branch. The change-scoped CI lint above reports no new issues.AI assistance
Hermes Agent using OpenAI GPT-5.6 Sol assisted with implementation and test orchestration. OpenAI Codex GPT-5.5 independently reviewed the final diff. The resulting changes were validated with the commands listed above.
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes