Skip to content

feat: add default StepAction catalog to Hub Resolver - #10420

Open
roian6 wants to merge 1 commit into
tektoncd:mainfrom
roian6:tekton-10419-stepaction-default
Open

feat: add default StepAction catalog to Hub Resolver#10420
roian6 wants to merge 1 commit into
tektoncd:mainfrom
roian6:tekton-10419-stepaction-default

Conversation

@roian6

@roian6 roian6 commented Jul 10, 2026

Copy link
Copy Markdown

Changes

  • Add default-artifact-hub-stepaction-catalog with the shipped default git-clone-stepaction.
  • Use that default when Artifact Hub StepAction requests omit catalog in both resolver implementations.
  • Preserve explicit StepAction catalogs and existing Task defaults for older/custom ConfigMaps without the new key.
  • Update Hub Resolver configuration docs and the StepAction example.

Fixes #10419

Verification

  • go test -race -count=1 ./pkg/resolution/resolver/hub ./pkg/remoteresolution/resolver/hub
  • make test-unit-verbose-and-race
  • go vet ./...
  • golangci-lint run --modules-download-mode=vendor --new-from-rev=origin/main --max-issues-per-linter=0 --max-same-issues=0 --timeout=10m (0 issues)
  • ./hack/verify-codegen.sh (up to date)
  • yamllint -c .yamllint config/resolvers/hubresolver-config.yaml
  • ./hack/verify-agent-readiness.sh

pre-commit run --all-files runs all unit tests successfully, but its full-repository lint/private-key hooks are currently blocked by existing origin/main findings: the docs/auth.md test fixture is detected as a private key and full lint reports 161 issues on both clean origin/main and this branch. The change-scoped CI lint above reports no new issues.

AI assistance

Hermes Agent using OpenAI GPT-5.6 Sol assisted with implementation and test orchestration. OpenAI Codex GPT-5.5 independently reviewed the final diff. The resulting changes were validated with the commands listed above.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed (see baseline note above)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

The Hub Resolver now defaults the Artifact Hub catalog to `git-clone-stepaction` when resolving a StepAction without an explicit `catalog` parameter.

Configure git-clone-stepaction as the default Artifact Hub catalog for StepAction resources in both resolver implementations. Update the shipped ConfigMap and documentation, and cover default, missing-key, and compatibility behavior.

Fixes tektoncd#10419
@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 10, 2026
@tekton-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign waveywaves after the PR has been reviewed.
You can assign the PR to them by writing /assign @waveywaves in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 10, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

  • ✅ login: roian6 / name: roian6 (3c1e702)

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2026
@roian6

roian6 commented Jul 10, 2026

Copy link
Copy Markdown
Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 10, 2026

@khrm khrm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@roian6

roian6 commented Jul 26, 2026

Copy link
Copy Markdown
Author

/retest

@roian6

roian6 commented Jul 26, 2026

Copy link
Copy Markdown
Author

Follow-up: /retest queued the Tekton CI check, but the failed GitHub Actions run 29105168437 is still on its prior result. I also attempted a failed-job rerun directly, but GitHub does not permit this fork contributor to rerun the upstream workflow.

The only test failure was the k8s-latest / stable E2E matrix hitting proxy.golang.org with an HTTP/2 INTERNAL_ERROR; the build, lint, unit checks, other E2E matrices, and generated-code checks passed. Could a maintainer rerun the failed GitHub Actions job when convenient?

@vdemeester vdemeester left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default value is wrong and we would need to create a tekton-catalog-stepactions catalog.. But with tektoncd/community#1283, these default values would quickly not make sense and be "frozen in time" even..

cc @tektoncd/core-maintainers

# the default Artifact Hub Pipeline catalog from where to pull the resource.
default-artifact-hub-pipeline-catalog: "tekton-catalog-pipelines"
# the default Artifact Hub StepAction catalog from where to pull the resource.
default-artifact-hub-stepaction-catalog: "git-clone-stepaction"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be this one, but most likely tekton-catalog-stepactions isn't it ? But it was never created..

@roian6

roian6 commented Jul 30, 2026

Copy link
Copy Markdown
Author

Thanks, that makes sense. git-clone-stepaction is repository-specific rather than a kind-wide StepAction catalog, so using it as the default would only work for git-clone and would misroute other StepActions. With the distributed catalog direction in tektoncd/community#1283, keeping catalog explicit for StepActions seems more appropriate.

I’ll hold off on changing the PR until the core maintainers confirm the intended direction; I’m also happy to close it if the default-catalog approach is no longer desired.

@vdemeester

Copy link
Copy Markdown
Member

@roian6 thanks for your understanding. I want inputs for other mainatiners about what should we do there 👼🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hub Resolver: Add a default catalog for StepAction kind

4 participants