Skip to content

Fix lint failure: correct gofmt alignment in FeatureFlags struct (TEP-0048 default results) - #10320

Closed
pritidesai with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-lint-job-failure
Closed

Fix lint failure: correct gofmt alignment in FeatureFlags struct (TEP-0048 default results)#10320
pritidesai with Copilot wants to merge 4 commits into
mainfrom
copilot/fix-lint-job-failure

Conversation

Copilot AI commented Jun 18, 2026

Copy link
Copy Markdown

The lint CI job was failing because PR #9653 (TEP-0048: default results) introduced incorrect struct field alignment in pkg/apis/config/feature_flags.go when adding EnableDefaultResults. gofmt requires all consecutive struct fields to align to the longest field name; the PR broke this by using inconsistent tab stops.

Changes

  • pkg/apis/config/feature_flags.go: Re-align FeatureFlags struct fields so EnableDefaultResults and siblings align to EnableTerminationMessageCompression (longest name in the block):
    // Before (fails gofmt)
    EnableDefaultResults         bool   `json:"enableDefaultResults,omitempty"`
    EnableWaitExponentialBackoff         bool `json:"enableWaitExponentialBackoff,omitempty"`
    EnableTerminationMessageCompression bool `json:"enableTerminationMessageCompression,omitempty"`
    
    // After (passes gofmt)
    EnableDefaultResults                bool   `json:"enableDefaultResults,omitempty"`
    EnableWaitExponentialBackoff        bool   `json:"enableWaitExponentialBackoff,omitempty"`
    EnableTerminationMessageCompression bool   `json:"enableTerminationMessageCompression,omitempty"`
  • test/e2e-tests.sh: Fix spurious comma in printf format string that would have been printed literally instead of acting as a separator.
  • All remaining changes are the TEP-0048 default results feature from PR TEP-0048: default results #9653 (new Default field on TaskResult, validation, reconciler wiring, conversion, deep copy, examples).

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 18, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jun 18, 2026

Copy link
Copy Markdown

CLA Not Signed

@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 18, 2026
pritidesai and others added 2 commits June 18, 2026 23:51
This commit introduces default results, allowing task authors to specify a
default value for a result. If a task does not produce a value for that
result during execution, the specified default will be used. This ensures that
downstream tasks referencing that result can still resolve params consuming
the results, preventing unncessary failures in the pipeline.

With this change, if a task author does not define a default value and none of
the steps produce the corresponding result, the entire taskRun will be marked
as failed.

For more details, please refer to TEP-0048

Co-authored-by: Vinamra Jain <vinjain@redhat.com>

Assisted-by: Claude 4.6 Sonnet

Signed-off-by: Priti Desai <pdesai@us.ibm.com>
@tekton-robot

Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from pritidesai after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2026
Copilot AI changed the title [WIP] Fix failing GitHub Actions job lint Fix lint failure: correct gofmt alignment in FeatureFlags struct (TEP-0048 default results) Jun 18, 2026
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 18, 2026
Copilot AI requested a review from pritidesai June 18, 2026 23:59
@pritidesai pritidesai closed this Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants