Fix lint failure: correct gofmt alignment in FeatureFlags struct (TEP-0048 default results) - #10320
Closed
pritidesai with Copilot wants to merge 4 commits into
Closed
Fix lint failure: correct gofmt alignment in FeatureFlags struct (TEP-0048 default results)#10320pritidesai with Copilot wants to merge 4 commits into
pritidesai with Copilot wants to merge 4 commits into
Conversation
|
This commit introduces default results, allowing task authors to specify a default value for a result. If a task does not produce a value for that result during execution, the specified default will be used. This ensures that downstream tasks referencing that result can still resolve params consuming the results, preventing unncessary failures in the pipeline. With this change, if a task author does not define a default value and none of the steps produce the corresponding result, the entire taskRun will be marked as failed. For more details, please refer to TEP-0048 Co-authored-by: Vinamra Jain <vinjain@redhat.com> Assisted-by: Claude 4.6 Sonnet Signed-off-by: Priti Desai <pdesai@us.ibm.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job lint
Fix lint failure: correct gofmt alignment in FeatureFlags struct (TEP-0048 default results)
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lintCI job was failing because PR #9653 (TEP-0048: default results) introduced incorrect struct field alignment inpkg/apis/config/feature_flags.gowhen addingEnableDefaultResults.gofmtrequires all consecutive struct fields to align to the longest field name; the PR broke this by using inconsistent tab stops.Changes
pkg/apis/config/feature_flags.go: Re-alignFeatureFlagsstruct fields soEnableDefaultResultsand siblings align toEnableTerminationMessageCompression(longest name in the block):test/e2e-tests.sh: Fix spurious comma inprintfformat string that would have been printed literally instead of acting as a separator.Defaultfield onTaskResult, validation, reconciler wiring, conversion, deep copy, examples).Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes