Update reusable-e2e.yaml to remove ko version#1766
Merged
Conversation
Removed version specification for ko-build/setup-ko action. The latest build has ko-build/ko#1694
tekton-robot
added
the
size/XS
Contributor
|
/approve |
tekton-robot
added
the
approved
Member
|
@khrm latest was adding an issue , and version is pinned because of this #1738 In operator added this fix with latest ko tektoncd/operator@84c7e7f |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
ko v0.19 unconditionally attempts HTTPS when writing SBOMs, causing the E2E job to fail with "http: server gave HTTP response to HTTPS client" against the plain-HTTP KinD registry (registry.local:5000). Set KO_FLAGS=--insecure-registry in the reusable e2e workflow env block and forward it to the ko apply call in e2e-common.sh so that both image pushes and SBOM writes use plain HTTP for the local registry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Khurram Baig <kbaig@redhat.com>
Contributor
Author
|
@jkhelil Let's merge this. |
Member
|
/approve |
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enarha, jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed version specification for ko-build/setup-ko action.
The latest release has ko-build/ko#1694
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes