This repository was archived by the owner on Jun 23, 2026. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
랭킹페이지 페이지네이션 API 연결 구현 완료 #26
Open
xhmxnjxx
wants to merge
23
commits into
develop
Choose a base branch
from
Feature_Issue#11_Leaderboard_Pagination_API
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
72dffc5
python 상수 오탈자 수정
xhmxnjxx 3e18e6d
html 상수 오탈자 수정
xhmxnjxx a5da9b8
c 상수 오탈자 수정
xhmxnjxx 8fc1331
로그인 된 상태에서 로그인 화면 접속 시도 시 메인 화면으로 redirect 하는 기능 구현
xhmxnjxx 9313565
Leaderboard Pagination 전체 페이지 구현
xhmxnjxx 4d5db8d
리더보드 페이지 페이지네이션 API 연결 구현
xhmxnjxx 4796142
fix: Change || to ?? operator
hajeong-lim b87ca20
랭킹보드에서 2페이지 넘어갈 시 Leaderboard 순위 버그 수정
xhmxnjxx 2968d6e
fix: Remove unnecessary theme imports
hajeong-lim 1d56863
fix: Rename PortalModal/style.js to styles.js
hajeong-lim 05a55c8
fix: Move common styles in PortalModal to component/common/styles.js
hajeong-lim e1361ed
fix: Fix Modal style imports
hajeong-lim 581e50d
fix: Renmae style.js to styles.js
hajeong-lim a1624df
fix: Chagne import path in PortalModal
hajeong-lim 8c0c397
Merge pull request #24 from jaychang99/Feature_#11_Modal_issues
hajeong-lim 4faedc4
LEADERBOARD_PAGE_SIZE 상수 처리
xhmxnjxx 72c4ef3
API 구조 변경에 따른 코드 변경 및 develop branch merge conflict 처리
xhmxnjxx 88675b0
const {offset, setOffset} 삭제
xhmxnjxx 8932ecb
주석 처리
xhmxnjxx d774186
.env 파일 추가
xhmxnjxx 6186ea3
Merge branch 'Feature_Issue#11_Leaderboard_Pagination_API' of https:/…
xhmxnjxx 82c0e44
Leaderboard props에서 pageNumber, pageSize 삭제
xhmxnjxx 8604015
console.log 부분 삭제
xhmxnjxx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| REACT_APP_API_ENDPOINT = https://api.tadak.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import styled from "@emotion/styled/macro"; | ||
| import { hexToRgba } from "utils/color"; | ||
| import { motion } from "framer-motion"; | ||
|
|
||
| export const StyledModal = styled(motion.div)` | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| align-items: center; | ||
| font-size: 14px; | ||
| gap: 16px; | ||
| border-radius: 10px; | ||
| padding: 40px 20px; | ||
| position: fixed; | ||
| top: 50%; | ||
| left: 50%; | ||
| transform: translate(-50%, -50%); | ||
| z-index: 100; | ||
| width: 400px; | ||
| background: ${({ theme }) => theme.color.modalBG}; | ||
| box-shadow: 0px 4px 4px rgba(0, 0, 0, 0.25); | ||
| `; | ||
|
|
||
| export const DimmedArea = styled.div` | ||
| position: fixed; | ||
| top: 0; | ||
| left: 0; | ||
|
|
||
| display: flex; | ||
| justify-content: center; | ||
| align-items: center; | ||
|
|
||
| width: 100%; | ||
| height: 100%; | ||
|
|
||
| background-color: ${({ theme }) => hexToRgba(theme.color.white, 0.2)}; | ||
|
|
||
| z-index: 1000; | ||
| `; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import styled from "@emotion/styled/macro"; | ||
|
|
||
| // TODO: 일단 Modal에서만 사용하는 스타일임, Modal 이외의 style에서도 활용가능하도록 일반화 | ||
| export const ModalIcon = styled.img` | ||
| width:40px; | ||
| height:40px; | ||
| ` | ||
|
|
||
| export const ModalText = styled.div` | ||
| color: ${({ theme, color }) => color ?? theme.color.white}; | ||
| ` | ||
|
|
||
| export const ModalTitle = styled(ModalText)` | ||
| font-size: 40px; | ||
| font-weight: 700; | ||
| ` | ||
|
|
||
| export const ModalHeader = styled(ModalText)` | ||
| font-size: 36px; | ||
| font-weight: 700; | ||
| ` | ||
|
|
||
| export const ModalBody = styled(ModalText)` | ||
| font-size: 16px; | ||
| ` | ||
|
|
||
| export const ModalButton = styled.div` | ||
| padding: 10px; | ||
| width: 100%; | ||
| background-color: #bfcdf0; | ||
| border-radius: 10px; | ||
| cursor: pointer; | ||
| font-size: 16px; | ||
| color: #26262d; | ||
| text-align: center; | ||
| font-weight: bold; | ||
| &.active { | ||
| background-color: ${({ theme }) => theme.color.primary500}; | ||
| } | ||
|
|
||
| &:hover { | ||
| background-color: ${({ theme }) => theme.color.primary200}; | ||
| } | ||
| transition: 0.3s; | ||
| ` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const LEADERBOARD_PAGE_SIZE = 10; | ||
|
jaychang99 marked this conversation as resolved.
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오홍 맞네요 이제 API 자체에서 ranking 을 주니까
pageSize와pageNumber로 계산을 안 해도 돼서 좋군요. 그러면 prop 에서도 받아오지 않아도 좋을 것 같은데 어떻게 생각하시나용?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
앗 그러네요 ,,, 수정할게요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
확인했습니다 본 thread 는 resolve 하겟습니다!