fix: rename .talon files that shadow same-named .talon-list files - #2312
fix: rename .talon files that shadow same-named .talon-list files#2312wesleyboar wants to merge 2 commits into
Conversation
Talon skips a `.talon-list` when a `.talon` file shares its basename in the same directory, so `user.emoji` and `user.top_level_domain` both registered with zero entries and their commands could never match. - `emoji.talon` and `top_level_domain.talon` were the only two collisions in the repo; sibling lists (`emoticon`, `kaomoji`) were unaffected - no command grammar or list content changed Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Note
tags/emoji/insert_emoji.talon
Verifying this half needs Slack or Discord focus: those are the only two contexts that enable tag: user.emoji, which gates these rules. emoticon and kaomoji were never affected, since their list files have no same-stem .talon shadowing them.
Note
core/top_level_domain/insert_top_level_domain.talon
The insert_ prefix follows the existing core/vocabulary/edit_vocabulary.talon precedent for naming a command file differently from its sibling list files. Renaming the .talon-list instead would fix the shadowing equally well, but would break the convention that a list file is named after the list it defines.
Talon skips a `.talon-list` when a `.talon` file shares its basename in the same directory, so `user.emoji` and `user.top_level_domain` both registered with zero entries and their commands could never match. Relates-to talonhub#2312 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
I would prefer the more subtle approach of adding a plural |
AndreasArvidsson
left a comment
There was a problem hiding this comment.
Feedback from the community session. We would prefer if you pluralize the list file name. eg emojis.talon-list. Don't rename the list itself just the file name.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Overview
Fixes
user.emojianduser.top_level_domainregistering with zero entries, which made their commands unmatchable.Changes
.talonfile that shadowed a same-named.talon-listemoji.talon→insert_emoji.talontop_level_domain.talon→insert_top_level_domain.talonTesting
Top-Level Domains
main, run:0.8..comis typed.Emojis
main, run:0.28.Notes
.talon-listwhose basename matches a.talonfile in the same directory, loggingDEBUG [ ]instead ofDEBUG [+]— no warning or error..talon-listfiles.