Add common C# keywords and functions to Talon lists - #2225
Add common C# keywords and functions to Talon lists#2225Mark-Phillipson wants to merge 4 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: abe99cb597
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
FireChickenProductivity
left a comment
FireChickenProductivity
left a comment
There was a problem hiding this comment.
I am glad to see someone else helping expand our language support!
It is generally recommended to put separate features in separate pull requests for the reasons outlined in the CONTRIBUTING.md file. That would probably get one of your list changes merged faster.
| code.language: csharp | ||
| """ | ||
|
|
||
| mod.list("code_common_function", desc="Common C# functions") |
There was a problem hiding this comment.
You should not be redefining these lists on a module.
| string: ".ToString" | ||
| length: ".Length" |
There was a problem hiding this comment.
We usually use user.code_common_method for methods.
| @@ -0,0 +1,90 @@ | |||
| list: user.code_keyword | |||
| code.language: csharp | |||
| code.language: aspnetcorerazor | |||
There was a problem hiding this comment.
Can code.language get set to this if we do not have the language defined in Community? Can you check if this triggers with help scope? code.language is under Misc if a language is detected.
There was a problem hiding this comment.
From the community backlog session — we are aware that this is in another PR. Consider removing code.language: aspnetcorerazor until we have a decision on that PR.
| @@ -0,0 +1,90 @@ | |||
| list: user.code_keyword | |||
| code.language: csharp | |||
| code.language: aspnetcorerazor | |||
There was a problem hiding this comment.
From the community backlog session — we are aware that this is in another PR. Consider removing code.language: aspnetcorerazor until we have a decision on that PR.
| abstract: " abstract " | ||
| add: " add " | ||
| alias: " alias " | ||
| ascending: " ascending " | ||
| async: " async " | ||
| await: " await " | ||
| base: " base " | ||
| boolean: " bool " | ||
| break: " break " | ||
| case: " case " | ||
| catch: " catch " | ||
| class: " class " | ||
| const: " const " | ||
| continue: " continue " | ||
| default: " default " | ||
| delegate: " delegate " | ||
| descending: " descending " | ||
| double: " double " | ||
| dynamic: " dynamic " | ||
| else: " else " | ||
| enum: " enum " | ||
| equals: " equals " | ||
| event: " event " | ||
| explicit: " explicit " | ||
| extern: " extern " | ||
| false: " false " | ||
| finally: " finally " | ||
| for: " for " | ||
| foreach: " foreach " | ||
| from: " from " | ||
| get: " get " | ||
| global: " global " | ||
| group: " group " | ||
| if: " if " | ||
| implicit: " implicit " | ||
| in: " in " | ||
| integer: " int " | ||
| interface: " interface " | ||
| internal: " internal " | ||
| into: " into " | ||
| is: " is " | ||
| join: " join " | ||
| let: " let " | ||
| lock: " lock " | ||
| name of: " nameof " | ||
| namespace: " namespace " | ||
| new: " new " | ||
| null: " null " | ||
| operator: " operator " | ||
| order by: " orderby " | ||
| out: " out " | ||
| override: " override " | ||
| params: " params " | ||
| partial: " partial " | ||
| private: " private " | ||
| protected: " protected " | ||
| public: " public " | ||
| read only: " readonly " | ||
| ref: " ref " | ||
| remove: " remove " | ||
| required: " required " | ||
| return: " return " | ||
| sealed: " sealed " | ||
| select: " select " | ||
| set: " set " | ||
| size of: " sizeof " | ||
| static: " static " | ||
| string: " string " | ||
| struct: " struct " | ||
| switch: " switch " | ||
| this: " this " | ||
| throw: " throw " | ||
| true: " true " | ||
| try: " try " | ||
| type of: " typeof " | ||
| unsafe: " unsafe " | ||
| using: " using " | ||
| value: " value " | ||
| var: " var " | ||
| virtual: " virtual " | ||
| volatile: " volatile " | ||
| void: " void " | ||
| where: " where " | ||
| while: " while " | ||
| yield: " yield " |
There was a problem hiding this comment.
From the community backlog session — our general pattern is not to include leading spaces in user.code_keyword (operators like "and" and "or" are rare exceptions). Only include trailing spaces where there is always expected to be something after it (not including punctuation like commas or semicolons).
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
lines/50-199
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30a507bb7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| mod.list("code_common_function", desc="Common C# functions") | ||
| mod.list("code_keyword", desc="Common C# keywords") |
There was a problem hiding this comment.
These lists are already declared as user.code_common_function in lang/tags/functions_common.py:6 and user.code_keyword in lang/tags/keywords.py:7. Because Talon module declarations share the user namespace, redeclaring them from a second module causes whichever declaration is registered second to fail; depending on load order, this can prevent either the C# action overrides or the shared keyword/common-function support from loading.
Useful? React with 👍 / 👎.
| integer: "int.TryParse" | ||
| print: "Console.WriteLine" | ||
| string: ".ToString" | ||
| length: ".Length" |
There was a problem hiding this comment.
When a C# user invokes funk length for a standard string or array, UserActions.code_insert_function unconditionally appends parentheses, so this entry inserts .Length() rather than the valid .Length property access. This command therefore produces uncompilable C# for the common types the entry is intended to support.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,90 @@ | |||
| list: user.code_keyword | |||
| code.language: csharp | |||
| code.language: aspnetcorerazor | |||
There was a problem hiding this comment.
When VS Code reports code.language: aspnetcorerazor, this list becomes active, but the grammar consuming it remains disabled because lang/tags/keywords.talon requires user.code_keywords and the only repository context enabling that tag is lang/csharp/csharp.talon, which matches only csharp. Consequently keyword public and the other new mappings are unavailable in the Razor context despite this header explicitly targeting it.
Useful? React with 👍 / 👎.
5 participants
This pull request introduces a new Talon list file that contains the C# keywords. Additionally, it moves the common functions related to C# into a Talon list to improve organization and accessibility. These changes aim to enhance the overall functionality for users working with C# in Talon.