Migrate block comment commands to actions - #2171
Migrate block comment commands to actions#2171FireChickenProductivity wants to merge 49 commits into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
for more information, see https://pre-commit.ci
|
Is the plan to convert these to snippets in a follow up PR? |
There are no followup plans yet. Suggestions are welcome. This PR is mostly to satisfy an ancient todo comment. |
There was a problem hiding this comment.
From the community backlog session — makes sense as a first step, migrating the implementations from voice commands to actions. Could you please rename all the new actions to start with code_block_? Also for the actions that include a new optional argument, can you use snippet insertion or a single insert to insert both the comment delimiters and contents in a single action? Thanks!
What about instead using |
for more information, see https://pre-commit.ci
|
There was no clear way to do the c like block comment insertion in a single insert without changing behavior. We may want to leave updating that one for a snippet migration follow up. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eceb6cf3ba
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0146ec8bd3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
Are my changes to the snippet code acceptable? (I am waiting for feedback before testing more thoroughly) |
nriley
left a comment
nriley
left a comment
There was a problem hiding this comment.
Plan for snippet phrases:
commentBlock.snippet: inline comment
commentMultilineBlock.snippet: block comment
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
lines/200-499
4 participants
Migrate block comment commands to use actions. I fixed one of the commands not always making the comment on a single line as a side effect of the snippet migration.
The differences between these commands are not very clear from the names. There is stuff to improve here, but I would prefer to make this PR just a migration.